From: Lukas Prediger <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection
Date: Sat, 11 Sep 2021 20:48:17 +0300 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Hi Randy, Hi Phil,
>> Hi Lukas,
>> Just a minor nit:
>> On 9/10/21 2:16 PM, Lukas Prediger wrote:
>> > +#define MEDIA_CHANGED_FLAG 0x1 /* Last detected media change was more \
>> > + * recent than last_media_change set by\
>> > + * caller. \
>> > + */
>> Drop the "continuation" backslashes.
>> They are not needed.
Hm, my IDE was complaining about these but I just tested building without and
that worked fine. No idea what that was about then..
> Dear Lukas,
> Happy to take these out for you and save you resubmitting.
> I'm very happy with patch anyway. Once I hear back from
> you I'll send onto Jens with my approval after one final test :-)
That would be very nice of you!
> Thanks again for the code.
My pleasure, and thanks for the helpful feedback!
next prev parent reply other threads:[~2021-09-11 22:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 21:16 [PATCH v3] drivers/cdrom: improved ioctl for media change detection Lukas Prediger
2021-09-10 21:41 ` Randy Dunlap
2021-09-11 11:00 ` Phillip Potter
2021-09-11 17:48 ` Lukas Prediger [this message]
2021-09-12 18:04 ` Phillip Potter
2021-09-12 19:12 ` Lukas Prediger
2021-09-13 7:50 ` Phillip Potter
2021-10-06 20:52 ` Randy Dunlap
2021-10-07 23:04 ` Phillip Potter
2021-09-13 23:09 Phillip Potter
2021-09-15 2:05 ` Jens Axboe
2021-09-16 23:07 ` Phillip Potter
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).