archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <>
To: Lihong Kou <>
Subject: Re: [PATCH v2] block: nvme: fix the NULL ptr bug in bio_integrity_verify_fn
Date: Mon, 13 Sep 2021 08:13:03 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> -	blk_integrity_unregister(disk);
> +	if (blk_get_integrity(disk))
> +		blk_integrity_unregister(disk);

Instead of open coding this in the callers I think we should make
blk_integrity_unregister a no-op if no integrity profile was registered.
Also please split this into two logically separate patches.

  reply	other threads:[~2021-09-13  6:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  2:49 [PATCH v2] block: nvme: fix the NULL ptr bug in bio_integrity_verify_fn Lihong Kou
2021-09-13  6:13 ` Christoph Hellwig [this message]
     [not found]   ` <>
2021-09-14  6:20     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).