From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk, martin.petersen@oracle.com
Cc: Lihong Kou <koulihong@huawei.com>,
kbusch@kernel.org, sagi@grimberg.me, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: [PATCH 3/3] nvme: remove the call to nvme_update_disk_info in nvme_ns_remove
Date: Tue, 14 Sep 2021 09:06:57 +0200 [thread overview]
Message-ID: <20210914070657.87677-4-hch@lst.de> (raw)
In-Reply-To: <20210914070657.87677-1-hch@lst.de>
There is no need to explicitly unregister the integrity profile when
deleting the gendisk.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/host/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 97f8211cf92c1..6600e138945e2 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3862,8 +3862,6 @@ static void nvme_ns_remove(struct nvme_ns *ns)
nvme_cdev_del(&ns->cdev, &ns->cdev_device);
del_gendisk(ns->disk);
blk_cleanup_queue(ns->queue);
- if (blk_get_integrity(ns->disk))
- blk_integrity_unregister(ns->disk);
down_write(&ns->ctrl->namespaces_rwsem);
list_del_init(&ns->list);
--
2.30.2
next prev parent reply other threads:[~2021-09-14 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 7:06 fix an integrity profile unregistration race Christoph Hellwig
2021-09-14 7:06 ` [PATCH 1/3] block: check if a profile is actually registered in blk_integrity_unregister Christoph Hellwig
2021-09-14 7:10 ` Sagi Grimberg
2021-09-14 7:06 ` [PATCH 2/3] block: flush the integrity workqueue " Christoph Hellwig
2021-09-14 7:19 ` Sagi Grimberg
2021-09-14 7:06 ` Christoph Hellwig [this message]
2021-09-14 7:19 ` [PATCH 3/3] nvme: remove the call to nvme_update_disk_info in nvme_ns_remove Sagi Grimberg
2021-09-15 2:03 ` fix an integrity profile unregistration race Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914070657.87677-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=koulihong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).