From: Christoph Hellwig <firstname.lastname@example.org> To: Bart Van Assche <email@example.com> Cc: Christoph Hellwig <firstname.lastname@example.org>, Jens Axboe <email@example.com>, Tejun Heo <firstname.lastname@example.org>, email@example.com, Ming Lei <firstname.lastname@example.org> Subject: Re: tear down file system I/O in del_gendisk Date: Tue, 21 Sep 2021 11:08:11 +0200 [thread overview] Message-ID: <20210921090811.GB336@lst.de> (raw) In-Reply-To: <email@example.com> On Mon, Sep 20, 2021 at 08:38:31PM -0700, Bart Van Assche wrote: > On 9/20/21 04:24, Christoph Hellwig wrote: >> Ming reported that for SCSI we have a lifetime problem now that >> the BDI moved from the request_queue to the disk as del_gendisk >> doesn't finish all outstanding file system I/O. It turns out >> this actually is an older problem, although the case where it could >> be hit before was very unusual (unbinding of a SCSI upper driver >> while the scsi_device stays around). This series fixes this by >> draining all I/O in del_gendisk. > > Several failures are reported when running blktests against Jens' for-next > branch if KASAN and lockdep are enabled. Is this patch series sufficient > to make blktests pass again? I don't see any new failures (I have a few consistent ones due to the fact that blktests is completly fucked up and wants to load modules everywhere which doesn't exactly work with builtin drivers). Care to post your issues?
next prev parent reply other threads:[~2021-09-21 9:08 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-20 11:24 Christoph Hellwig 2021-09-20 11:24 ` [PATCH 1/4] block: factor out a blk_try_enter_queue helper Christoph Hellwig 2021-09-21 3:17 ` Bart Van Assche 2021-09-20 11:24 ` [PATCH 2/4] block: split bio_queue_enter from blk_queue_enter Christoph Hellwig 2021-09-21 3:25 ` Bart Van Assche 2021-09-20 11:24 ` [PATCH 3/4] block: drain file system I/O on del_gendisk Christoph Hellwig 2021-09-20 11:24 ` [PATCH 4/4] block: keep q_usage_counter in atomic mode after del_gendisk Christoph Hellwig 2021-09-21 3:29 ` Bart Van Assche 2021-09-21 9:07 ` Christoph Hellwig 2021-09-21 3:38 ` tear down file system I/O in del_gendisk Bart Van Assche 2021-09-21 9:08 ` Christoph Hellwig [this message] 2021-09-21 14:24 ` Bart Van Assche 2021-09-21 22:33 ` Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210921090811.GB336@lst.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: tear down file system I/O in del_gendisk' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).