linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: <linux-block@vger.kernel.org>
Cc: Chaitanya Kulkarni <kch@nvidia.com>,
	Himanshu Madhani <himanshu.madhani@oracle.com>
Subject: [PATCH V2 3/8] loop: use sysfs_emit() in the sysfs autoclear show
Date: Wed, 22 Sep 2021 18:49:40 -0700	[thread overview]
Message-ID: <20210923014945.6229-4-chaitanyak@nvidia.com> (raw)
In-Reply-To: <20210923014945.6229-1-chaitanyak@nvidia.com>

From: Chaitanya Kulkarni <kch@nvidia.com>

sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for outputting sysfs content and it's possible to overrun the
PAGE_SIZE buffer length.

Use a generic sysfs_emit function that knows the size of the
temporary buffer and ensures that no overrun is done for offset
attribute.

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
 drivers/block/loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ec1329afc154..fd935b788c53 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -868,7 +868,7 @@ static ssize_t loop_attr_autoclear_show(struct loop_device *lo, char *buf)
 {
 	int autoclear = (lo->lo_flags & LO_FLAGS_AUTOCLEAR);
 
-	return sprintf(buf, "%s\n", autoclear ? "1" : "0");
+	return sysfs_emit(buf, "%s\n", autoclear ? "1" : "0");
 }
 
 static ssize_t loop_attr_partscan_show(struct loop_device *lo, char *buf)
-- 
2.29.0


  parent reply	other threads:[~2021-09-23  1:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23  1:49 [PATCH V2 0/8] loop: small clenaup Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 1/8] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 2/8] loop: use sysfs_emit() in the sysfs sizelimit show Chaitanya Kulkarni
2021-09-23  1:49 ` Chaitanya Kulkarni [this message]
2021-09-23  1:49 ` [PATCH V2 4/8] loop: use sysfs_emit() in the sysfs partscan show Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 5/8] loop: use sysfs_emit() in the sysfs dio show Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 6/8] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 7/8] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2021-09-23  1:49 ` [PATCH V2 8/8] loop: allow user to set the queue depth Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923014945.6229-4-chaitanyak@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=himanshu.madhani@oracle.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).