From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Yu Kuai <yukuai3@huawei.com>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V4 5/6] nvme: loop: clear NVME_CTRL_ADMIN_Q_STOPPED after admin queue is reallocated
Date: Thu, 14 Oct 2021 16:17:09 +0800 [thread overview]
Message-ID: <20211014081710.1871747-6-ming.lei@redhat.com> (raw)
In-Reply-To: <20211014081710.1871747-1-ming.lei@redhat.com>
The nvme-loop's admin queue may be freed and reallocated, and we have to
reset the flag of NVME_CTRL_ADMIN_Q_STOPPED so that the flag can match
with the quiesce state of the admin queue.
nvme-loop is the only driver to reallocate request queue, and not see
such usage in other nvme drivers.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
drivers/nvme/target/loop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 440e1544033b..eb1094254c82 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -384,6 +384,8 @@ static int nvme_loop_configure_admin_queue(struct nvme_loop_ctrl *ctrl)
error = PTR_ERR(ctrl->ctrl.admin_q);
goto out_cleanup_fabrics_q;
}
+ /* reset stopped state for the fresh admin queue */
+ clear_bit(NVME_CTRL_ADMIN_Q_STOPPED, &ctrl->ctrl.flags);
error = nvmf_connect_admin_queue(&ctrl->ctrl);
if (error)
--
2.31.1
next prev parent reply other threads:[~2021-10-14 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 8:17 [PATCH V4 0/6] blk-mq: support concurrent queue quiescing Ming Lei
2021-10-14 8:17 ` [PATCH V4 1/6] nvme: add APIs for stopping/starting admin queue Ming Lei
2021-10-14 8:17 ` [PATCH V4 2/6] nvme: apply nvme API to quiesce/unquiesce " Ming Lei
2021-10-14 8:17 ` [PATCH V4 3/6] nvme: prepare for pairing quiescing and unquiescing Ming Lei
2021-10-14 12:10 ` Christoph Hellwig
2021-10-14 8:17 ` [PATCH V4 4/6] nvme: paring quiesce/unquiesce Ming Lei
2021-10-14 8:17 ` Ming Lei [this message]
2021-10-14 8:17 ` [PATCH V4 6/6] blk-mq: support concurrent queue quiesce/unquiesce Ming Lei
2021-10-14 12:11 ` [PATCH V4 0/6] blk-mq: support concurrent queue quiescing Christoph Hellwig
2021-10-18 1:05 ` Ming Lei
2021-10-18 1:19 ` Jens Axboe
2021-10-20 0:23 ` Ming Lei
2021-10-20 0:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014081710.1871747-6-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).