From: Jens Axboe <axboe@kernel.dk>
To: linux-block@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 12/14] block: align blkdev_dio inlined bio to a cacheline
Date: Sat, 16 Oct 2021 19:37:46 -0600 [thread overview]
Message-ID: <20211017013748.76461-13-axboe@kernel.dk> (raw)
In-Reply-To: <20211017013748.76461-1-axboe@kernel.dk>
We get all sorts of unreliable and funky results since the bio is
designed to align on a cacheline, which it does not when inlined like
this.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
block/fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/fops.c b/block/fops.c
index 1d4f862950bb..7eebd590342b 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -137,7 +137,7 @@ struct blkdev_dio {
size_t size;
atomic_t ref;
unsigned int flags;
- struct bio bio;
+ struct bio bio ____cacheline_aligned_in_smp;
};
static struct bio_set blkdev_dio_pool;
--
2.33.1
next prev parent reply other threads:[~2021-10-17 1:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 1:37 [PATCHSET 0/14] Various block layer optimizations Jens Axboe
2021-10-17 1:37 ` [PATCH 01/14] block: inline fast path of driver tag allocation Jens Axboe
2021-10-18 8:42 ` Christoph Hellwig
2021-10-18 14:38 ` Jens Axboe
2021-10-17 1:37 ` [PATCH 02/14] block: don't bother iter advancing a fully done bio Jens Axboe
2021-10-18 8:42 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 03/14] block: remove useless caller argument to print_req_error() Jens Axboe
2021-10-18 8:42 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 04/14] block: move update request helpers into blk-mq.c Jens Axboe
2021-10-18 8:43 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 05/14] block: don't call blk_status_to_errno() for success status Jens Axboe
2021-10-18 8:53 ` Christoph Hellwig
2021-10-18 10:49 ` Pavel Begunkov
2021-10-17 1:37 ` [PATCH 06/14] block: store elevator state in request Jens Axboe
2021-10-18 8:58 ` Christoph Hellwig
2021-10-18 14:34 ` Jens Axboe
2021-10-19 22:21 ` Guillaume Tucker
2021-10-19 22:26 ` Jens Axboe
2021-10-17 1:37 ` [PATCH 07/14] block: change plugging to use a singly linked list Jens Axboe
2021-10-18 9:19 ` Christoph Hellwig
2021-10-18 16:10 ` Jens Axboe
2021-10-18 12:56 ` Pavel Begunkov
2021-10-18 13:34 ` Jens Axboe
2021-10-17 1:37 ` [PATCH 08/14] block: improve layout of struct request Jens Axboe
2021-10-18 9:19 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 09/14] block: only mark bio as tracked if it really is tracked Jens Axboe
2021-10-18 9:19 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 10/14] block: move blk_mq_tag_to_rq() inline Jens Axboe
2021-10-17 1:37 ` [PATCH 11/14] block: optimize blk_mq_rq_ctx_init() Jens Axboe
2021-10-18 9:20 ` Christoph Hellwig
2021-10-17 1:37 ` Jens Axboe [this message]
2021-10-18 9:21 ` [PATCH 12/14] block: align blkdev_dio inlined bio to a cacheline Christoph Hellwig
2021-10-18 14:36 ` Jens Axboe
2021-10-17 1:37 ` [PATCH 13/14] block: remove debugfs blk_mq_ctx dispatched/merged/completed attributes Jens Axboe
2021-10-18 9:21 ` Christoph Hellwig
2021-10-17 1:37 ` [PATCH 14/14] block: remove some blk_mq_hw_ctx debugfs entries Jens Axboe
2021-10-18 9:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017013748.76461-13-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).