From: Christoph Hellwig <hch@lst.de>
To: Daejun Park <daejun7.park@samsung.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: please revert the UFS HPB support
Date: Mon, 25 Oct 2021 09:07:55 +0200 [thread overview]
Message-ID: <20211025070755.GA7742@lst.de> (raw)
In-Reply-To: <20211025051654epcms2p36b259d237eb2b8b885210148118c5d3f@epcms2p3>
On Mon, Oct 25, 2021 at 02:16:54PM +0900, Daejun Park wrote:
> > before the kernel is due to go final. Can the problems identified by
> > Christoph be fixed within that timeframe?
>
> I'm checking to see if I can replace blk_execute_rq_nowait with
> blk_insert_cloned_request in the HPB code.
blk_insert_cloned_request is part of the problem. You can't just fan
out one request into two on the same queue.
FYI, 5.15 is supposed to be released end of this week (unless an -rc8)
happens. I don't think we can sit this out, we need to revert (or at
least disable) the code now.
next prev parent reply other threads:[~2021-10-25 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:42 please revert the UFS HPB support Christoph Hellwig
2021-10-21 15:13 ` Jens Axboe
2021-10-21 15:15 ` Christoph Hellwig
2021-10-21 15:17 ` Christoph Hellwig
2021-10-21 16:22 ` Bart Van Assche
2021-10-23 15:43 ` James Bottomley
[not found] ` <CGME20211023154316epcas2p208f95cf1e4a87a4b61d2daf1a2b3c725@epcms2p3>
2021-10-25 5:16 ` Daejun Park
2021-10-25 7:07 ` Christoph Hellwig [this message]
2021-10-25 11:39 ` James Bottomley
2021-10-23 1:54 ` Martin K. Petersen
2021-10-23 4:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025070755.GA7742@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).