From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>, Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH 2/2] block: attempt direct issue of plug list
Date: Wed, 27 Oct 2021 02:16:06 +0000 [thread overview]
Message-ID: <20211027021605.wk2hvwxlztabjjm5@shindev> (raw)
In-Reply-To: <e8930e4f-0359-9218-3006-14463d7fe68c@kernel.dk>
On Oct 26, 2021 / 08:42, Jens Axboe wrote:
> On 10/25/21 11:20 PM, Shinichiro Kawasaki wrote:
> > On Oct 19, 2021 / 06:08, Jens Axboe wrote:
> >> If we have just one queue type in the plug list, then we can extend our
> >> direct issue to cover a full plug list as well.
> >>
> >> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> >
> > Hi Jens, I tried out for-next branch and observed A WARNING "do not call
> > blocking ops when !TASK_RUNNING" [1]. Reverting this patch from the for-next
> > branch, the warning disappears. The warning was triggered when mkfs.xfs is
> > run for memory backed null_blk devices with "none" scheduler.
(snip)
>
> This one should fix it:
>
> https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.16/block&id=ff1552232b3612edff43a95746a4e78e231ef3d4
I confirmed that the patch fixes the warning. Good. Thank you Ming, Jens.
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2021-10-27 2:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:08 [PATCHSET v2] Improve plugging Jens Axboe
2021-10-19 12:08 ` [PATCH 1/2] block: change plugging to use a singly linked list Jens Axboe
2021-10-19 13:34 ` Christoph Hellwig
2021-10-19 13:45 ` Jens Axboe
2021-10-19 12:08 ` [PATCH 2/2] block: attempt direct issue of plug list Jens Axboe
2021-10-19 13:36 ` Christoph Hellwig
2021-10-19 13:45 ` Jens Axboe
2021-10-26 5:20 ` Shinichiro Kawasaki
2021-10-26 14:42 ` Jens Axboe
2021-10-27 2:16 ` Shinichiro Kawasaki [this message]
2021-10-27 1:13 ` Guenter Roeck
2021-10-27 2:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027021605.wk2hvwxlztabjjm5@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).