From: Keith Busch <kbusch@fb.com>
To: <linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-nvme@lists.infradead.org>
Cc: <axboe@kernel.dk>, Kernel Team <Kernel-team@fb.com>, <hch@lst.de>,
<bvanassche@acm.org>, <damien.lemoal@opensource.wdc.com>,
<ebiggers@kernel.org>, <pankydev8@gmail.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv5 00/11] direct-io dma alignment
Date: Tue, 31 May 2022 12:11:26 -0700 [thread overview]
Message-ID: <20220531191137.2291467-1-kbusch@fb.com> (raw)
From: Keith Busch <kbusch@kernel.org>
The most significant change from v4 is the alignment is now checked
prior to building the bio. This gets the expected EINVAL error for
misaligned userspace iovecs in all cases now (Eric Biggers).
I've removed the legacy fs change, so only iomap filesystems get to use
this alignement capability (Christoph Hellwig).
The block fops check for alignment returns a bool now (Damien).
Adjusted some comments, docs, and other minor style issues.
Reviews added for unchanged or trivially changed patches, removed
reviews for ones that changed more significantly.
As before, I tested using 'fio' with forced misaligned user buffers on
raw block, xfs, and ext4 (example raw block profile below).
[global]
filename=/dev/nvme0n1
ioengine=io_uring
verify=crc32c
rw=randwrite
iodepth=64
direct=1
[small]
stonewall
bsrange=4k-64k
iomem_align=4
[large]
stonewall
bsrange=512k-4M
iomem_align=100
Keith Busch (11):
block: fix infinite loop for invalid zone append
block/bio: remove duplicate append pages code
block: export dma_alignment attribute
block: introduce bdev_dma_alignment helper
block: add a helper function for dio alignment
block/merge: count bytes instead of sectors
block/bounce: count bytes instead of sectors
iov: introduce iov_iter_aligned
block: introduce bdev_iter_is_aligned helper
block: relax direct io memory alignment
fs: add support for dma aligned direct-io
Documentation/ABI/stable/sysfs-block | 9 +++
block/bio.c | 114 ++++++++++++---------------
block/blk-merge.c | 41 ++++++----
block/blk-sysfs.c | 7 ++
block/bounce.c | 13 ++-
block/fops.c | 16 ++--
fs/iomap/direct-io.c | 4 +-
include/linux/blkdev.h | 12 +++
include/linux/uio.h | 2 +
lib/iov_iter.c | 92 +++++++++++++++++++++
10 files changed, 219 insertions(+), 91 deletions(-)
--
2.30.2
next reply other threads:[~2022-05-31 19:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 19:11 Keith Busch [this message]
2022-05-31 19:11 ` [PATCHv5 01/11] block: fix infinite loop for invalid zone append Keith Busch
2022-06-01 8:03 ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 02/11] block/bio: remove duplicate append pages code Keith Busch
2022-05-31 19:11 ` [PATCHv5 03/11] block: export dma_alignment attribute Keith Busch
2022-05-31 19:11 ` [PATCHv5 04/11] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-31 19:11 ` [PATCHv5 05/11] block: add a helper function for dio alignment Keith Busch
2022-06-01 5:29 ` Christoph Hellwig
2022-06-01 8:04 ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 06/11] block/merge: count bytes instead of sectors Keith Busch
2022-06-01 8:05 ` Johannes Thumshirn
2022-05-31 19:11 ` [PATCHv5 08/11] iov: introduce iov_iter_aligned Keith Busch
2022-06-01 5:30 ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 09/11] block: introduce bdev_iter_is_aligned helper Keith Busch
2022-05-31 21:46 ` Eric Biggers
2022-06-01 5:31 ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 10/11] block: relax direct io memory alignment Keith Busch
2022-06-01 5:31 ` Christoph Hellwig
2022-05-31 19:11 ` [PATCHv5 11/11] fs: add support for dma aligned direct-io Keith Busch
2022-06-01 5:32 ` Christoph Hellwig
[not found] ` <20220531191137.2291467-8-kbusch@fb.com>
2022-06-01 7:04 ` [PATCHv5 07/11] block/bounce: count bytes instead of sectors Eric Biggers
2022-06-01 7:11 ` [PATCHv5 00/11] direct-io dma alignment Eric Biggers
2022-06-01 14:28 ` Keith Busch
2022-06-01 16:12 ` Keith Busch
2022-06-06 16:24 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531191137.2291467-1-kbusch@fb.com \
--to=kbusch@fb.com \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).