linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huawei.com>
To: <paolo.valente@linaro.org>, <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<shikemeng@huawei.com>
Subject: [PATCH 04/20] block, bfq: simpfy computation of bfqd->budgets_assigned
Date: Tue, 1 Nov 2022 17:34:01 +0800	[thread overview]
Message-ID: <20221101093417.10540-5-shikemeng@huawei.com> (raw)
In-Reply-To: <20221101093417.10540-1-shikemeng@huawei.com>

The computation of budgets_assigned is a little confusing as we only need
to check if it's updated more than 10 times. Simpfy the computation to
improve readability.

Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
---
 block/bfq-iosched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index b21c3711d69d..be69b0e061f7 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -175,7 +175,7 @@ static const int bfq_back_penalty = 2;
 static u64 bfq_slice_idle = NSEC_PER_SEC / 125;
 
 /* Minimum number of assigned budgets for which stats are safe to compute. */
-static const int bfq_stats_min_budgets = 194;
+static const int bfq_stats_min_budgets = 11;
 
 /* Default maximum budget values, in sectors and number of requests. */
 static const int bfq_default_max_budget = 16 * 1024;
@@ -3288,7 +3288,7 @@ static void __bfq_set_in_service_queue(struct bfq_data *bfqd,
 	if (bfqq) {
 		bfq_clear_bfqq_fifo_expire(bfqq);
 
-		bfqd->budgets_assigned = (bfqd->budgets_assigned * 7 + 256) / 8;
+		bfqd->budgets_assigned++;
 
 		if (time_is_before_jiffies(bfqq->last_wr_start_finish) &&
 		    bfqq->wr_coeff > 1 &&
-- 
2.30.0


  parent reply	other threads:[~2022-11-01  9:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  9:33 [PATCH 00/20] A few bugfix and cleanup patches for bfq-iosched Kemeng Shi
2022-11-01  9:33 ` [PATCH 01/20] block, bfq: fix typo in comment Kemeng Shi
2022-11-01  9:33 ` [PATCH 02/20] block, bfq: Update bfqd->max_budget with bfqd->lock held Kemeng Shi
2022-11-01  9:34 ` [PATCH 03/20] block, bfq: correct bfq_max_budget and bfq_min_budget Kemeng Shi
2022-11-01  9:34 ` Kemeng Shi [this message]
2022-11-01  9:34 ` [PATCH 05/20] block, bfq: recover the "service hole" if enough budget is left Kemeng Shi
2022-11-01  9:34 ` [PATCH 06/20] block, bfq: correct interactive weight-raise check in bfq_set_budget_timeout Kemeng Shi
2022-11-01  9:34 ` [PATCH 07/20] block, bfq: simpfy check for interactive bfqq in bfq_update_wr_data Kemeng Shi
2022-11-01  9:34 ` [PATCH 08/20] block, bfq: do srt filtering for interactive queues in bfq_completed_request Kemeng Shi
2022-11-01  9:34 ` [PATCH 09/20] block, bfq: remove redundant check if (bfqq->dispatched > 0) Kemeng Shi
2022-11-01  9:34 ` [PATCH 10/20] block, bfq: define and use soft_rt, in_burst and wr_or_deserves_wr only low_latency is enable Kemeng Shi
2022-11-01  9:34 ` [PATCH 11/20] block, bfq: remove unnecessary "wr" part of wr_or_deserves_wr Kemeng Shi
2022-11-01  9:34 ` [PATCH 12/20] block, bfq: start/restart service_from_wr accumulating correctly Kemeng Shi
2022-11-01  9:34 ` [PATCH 13/20] block,bfq: remove redundant nonrot_with_queueing check in bfq_setup_cooperator Kemeng Shi
2022-11-01  9:34 ` [PATCH 14/20] block, bfq: remove redundant oom_bfqq check for bfqq from bfq_find_close_cooperator Kemeng Shi
2022-11-01  9:34 ` [PATCH 15/20] block, bfq: some cleanups for function bfq_pos_tree_add_move Kemeng Shi
2022-11-01  9:34 ` [PATCH 16/20] block, bfq: remove unnecessary goto tag in __bfq_weights_tree_remove Kemeng Shi
2022-11-01  9:34 ` [PATCH 17/20] block, bfq: remove unnecessary traverse in bfq_add_to_burst Kemeng Shi
2022-11-01  9:34 ` [PATCH 18/20] block, bfq: remove unnecessary bfqq->next_rq = NULL in bfq_remove_request Kemeng Shi
2022-11-01  9:34 ` [PATCH 19/20] block, bfq: remove unnecessary local variable __bfqq in bfq_setup_merge Kemeng Shi
2022-11-01  9:34 ` [PATCH 20/20] block, bfq: remove unncessary process_ref check for merged queue " Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221101093417.10540-5-shikemeng@huawei.com \
    --to=shikemeng@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).