From: Kashyap Desai <kashyap.desai@broadcom.com>
To: John Garry <john.garry@huawei.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com, hare@suse.de
Subject: RE: [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags
Date: Mon, 6 Dec 2021 15:33:07 +0530 [thread overview]
Message-ID: <205b1962196d64a93184dc4023499e2e@mail.gmail.com> (raw)
In-Reply-To: <e6069080-61e7-4345-8ff3-a26756a1c76c@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
> -----Original Message-----
> From: John Garry [mailto:john.garry@huawei.com]
> Sent: Monday, December 6, 2021 3:28 PM
> To: Kashyap Desai <kashyap.desai@broadcom.com>; axboe@kernel.dk
> Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org;
> ming.lei@redhat.com; hare@suse.de
> Subject: Re: [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter()
> for shared tags
>
> On 26/11/2021 11:51, John Garry wrote:
> >> This patch set improves above call trace even after disk_util=0 is set.
> > ok, fine. Thanks for testing.
> >
> > So I guess that this is a regression, and you would want this series
> > for v5.16, right? My changes were made with v5.17 in mind.
> >
> > I am not sure how Jens feels about it, since the changes are
> > significant. It would be a lot easier to argue for v5.16 if we got to
> > this point earlier in the cycle...
> >
>
> note: I will now resend for 5.17 and add your tested-by, please let me
> know if
> unhappy about that.
John - 5.17 should be OK. I am doing additional testing and so far no issue.
Tested-by: Kashyap Desai <kashyap.desai@broadcom.com>
>
> > Anyway, it would be good to have full review first, so please help
> > with that.
> >
> > @Ming, can you please give feedback on 3/3 here?
>
> Thanks and also to Hannes for the reviews.
>
> john
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2021-12-06 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 11:27 [PATCH RFT 0/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-11-02 11:27 ` [PATCH RFT 1/3] blk-mq: Drop busy_iter_fn blk_mq_hw_ctx argument John Garry
2021-11-09 3:02 ` Ming Lei
2021-11-28 10:39 ` Hannes Reinecke
2021-11-02 11:27 ` [PATCH RFT 2/3] blk-mq: Delete busy_iter_fn John Garry
2021-11-09 3:05 ` Ming Lei
2021-11-28 10:40 ` Hannes Reinecke
2021-11-02 11:27 ` [PATCH RFT 3/3] blk-mq: Optimise blk_mq_queue_tag_busy_iter() for shared tags John Garry
2021-11-28 10:43 ` Hannes Reinecke
2021-11-29 2:19 ` Ming Lei
2021-11-15 15:56 ` [PATCH RFT 0/3] " John Garry
2021-11-15 16:31 ` Kashyap Desai
2021-11-25 13:46 ` Kashyap Desai
2021-11-25 14:09 ` John Garry
2021-11-26 11:25 ` Kashyap Desai
2021-11-26 11:51 ` John Garry
2021-12-06 9:57 ` John Garry
2021-12-06 10:03 ` Kashyap Desai [this message]
2021-12-08 13:04 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=205b1962196d64a93184dc4023499e2e@mail.gmail.com \
--to=kashyap.desai@broadcom.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).