linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Stefan Haberland <sth@linux.ibm.com>
Cc: linux-block@vger.kernel.org, linux-s390@vger.kernel.org,
	hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
	borntraeger@de.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH 1/1] s390/dasd: fix endless loop after read unit address configuration
Date: Thu, 1 Aug 2019 20:47:51 -0600	[thread overview]
Message-ID: <20c4971d-68cd-b4d0-fb40-deef771602b1@kernel.dk> (raw)
In-Reply-To: <20190801110630.82432-2-sth@linux.ibm.com>

On 8/1/19 5:06 AM, Stefan Haberland wrote:
> After getting a storage server event that causes the DASD device driver
> to update its unit address configuration during a device shutdown there is
> the possibility of an endless loop in the device driver.
> 
> In the system log there will be ongoing DASD error messages with RC: -19.
> 
> The reason is that the loop starting the ruac request only terminates when
> the retry counter is decreased to 0. But in the sleep_on function there are
> early exit paths that do not decrease the retry counter.
> 
> Prevent an endless loop by handling those cases separately.
> 
> Remove the unnecessary do..while loop since the sleep_on function takes
> care of retries by itself.

Applied for 5.3, thanks.

-- 
Jens Axboe


  reply	other threads:[~2019-08-02  2:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 11:06 [PATCH 0/1] sending DASD patches through linux-block Stefan Haberland
2019-08-01 11:06 ` [PATCH 1/1] s390/dasd: fix endless loop after read unit address configuration Stefan Haberland
2019-08-02  2:47   ` Jens Axboe [this message]
2019-08-02  2:47 ` [PATCH 0/1] sending DASD patches through linux-block Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20c4971d-68cd-b4d0-fb40-deef771602b1@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hoeppner@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sth@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).