From: Jens Axboe <axboe@kernel.dk>
To: Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v2] block: Suppress uevent for hidden device when removed
Date: Thu, 11 Mar 2021 11:48:48 -0700 [thread overview]
Message-ID: <2117129c-368f-41e9-5f2d-ad7430c40ec0@kernel.dk> (raw)
In-Reply-To: <20210311151917.136091-1-dwagner@suse.de>
On 3/11/21 8:19 AM, Daniel Wagner wrote:
> register_disk() suppress uevents for devices with the GENHD_FL_HIDDEN
> but enables uevents at the end again in order to announce disk after
> possible partitions are created.
>
> When the device is removed the uevents are still on and user land sees
> 'remove' messages for devices which were never 'add'ed to the system.
>
> KERNEL[95481.571887] remove /devices/virtual/nvme-fabrics/ctl/nvme5/nvme0c5n1 (block)
>
> Let's suppress the uevents for GENHD_FL_HIDDEN by not enabling the
> uevents at all.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-03-11 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 15:19 [PATCH v2] block: Suppress uevent for hidden device when removed Daniel Wagner
2021-03-11 15:54 ` Christoph Hellwig
2021-03-11 16:06 ` Martin Wilck
2021-03-11 18:48 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2117129c-368f-41e9-5f2d-ad7430c40ec0@kernel.dk \
--to=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).