Linux-Block Archive on lore.kernel.org
 help / Atom feed
* [PATCH] block: avoid setting wbt_lat_usec to current value
@ 2019-02-11 10:10 Aleksei Zakharov
  2019-02-11 10:31 ` Johannes Thumshirn
  2019-02-11 15:20 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Aleksei Zakharov @ 2019-02-11 10:10 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, Aleksei Zakharov

There's no reason to set wbt min lat and freeze request queue
if current value is the same.

Signed-off-by: Aleksei Zakharov <zakharov.a.g@yandex.ru>
---
 block/blk-sysfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 590d1ef..d0df883 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -468,6 +468,9 @@ static ssize_t queue_wb_lat_store(struct request_queue *q, const char *page,
 	else if (val >= 0)
 		val *= 1000ULL;
 
+	if (wbt_get_min_lat(q) == val)
+		return count;
+
 	/*
 	 * Ensure that the queue is idled, in case the latency update
 	 * ends up either enabling or disabling wbt completely. We can't
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: avoid setting wbt_lat_usec to current value
  2019-02-11 10:10 [PATCH] block: avoid setting wbt_lat_usec to current value Aleksei Zakharov
@ 2019-02-11 10:31 ` Johannes Thumshirn
  2019-02-11 15:20 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2019-02-11 10:31 UTC (permalink / raw)
  To: Aleksei Zakharov; +Cc: axboe, linux-block

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: avoid setting wbt_lat_usec to current value
  2019-02-11 10:10 [PATCH] block: avoid setting wbt_lat_usec to current value Aleksei Zakharov
  2019-02-11 10:31 ` Johannes Thumshirn
@ 2019-02-11 15:20 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-02-11 15:20 UTC (permalink / raw)
  To: Aleksei Zakharov; +Cc: linux-block

On 2/11/19 3:10 AM, Aleksei Zakharov wrote:
> There's no reason to set wbt min lat and freeze request queue
> if current value is the same.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 10:10 [PATCH] block: avoid setting wbt_lat_usec to current value Aleksei Zakharov
2019-02-11 10:31 ` Johannes Thumshirn
2019-02-11 15:20 ` Jens Axboe

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox