linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* A possible divide by zero bug in blk_mq_map_queues
@ 2021-05-14  8:28 Yiyuan guo
  2021-05-14  8:34 ` Hannes Reinecke
  0 siblings, 1 reply; 5+ messages in thread
From: Yiyuan guo @ 2021-05-14  8:28 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, Yiyuan guo

In block/blk-mq-cpumap.c, blk_mq_map_queues has the following code:

int blk_mq_map_queues(struct blk_mq_queue_map *qmap) {
    ...
    unsigned int nr_queues = qmap->nr_queues;
    unsigned q = 0;
    ...
    for_each_present_cpu(cpu) {
        if (q >= nr_queues)
            break;
        ...
    }

    for_each_possible_cpu(cpu) {
        ...
        if (q < nr_queues) {
            map[cpu] = queue_index(qmap, nr_queues, q++);
        } else {
           ...
            if (first_sibling == cpu)
                map[cpu] = queue_index(qmap, nr_queues, q++);

        }
    }
}

if qmap->nr_queues equals to zero when entering the function, then by
passing zero to function queue_index we have a divide by zero bug:

static int queue_index(struct blk_mq_queue_map *qmap,
               unsigned int nr_queues, const int q)
{
    return qmap->queue_offset + (q % nr_queues);
}

It seems possible to me that qmap->nr_queues may equal zero because
this field is explicitly checked in other functions.

For example, in the function blk_mq_map_swqueue (block/blk-mq.c),
there is a check comparing nr_queues with 0:

for (j = 0; j < set->nr_maps; j++) {
            if (!set->map[j].nr_queues) {
                ...
                continue;
            }
            ...
}

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-14  9:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14  8:28 A possible divide by zero bug in blk_mq_map_queues Yiyuan guo
2021-05-14  8:34 ` Hannes Reinecke
2021-05-14  9:16   ` [PATCH] block: add protection for divide by zero " Yiyuan GUO
2021-05-14  9:24     ` Hannes Reinecke
2021-05-14  9:38       ` [PATCH v2] " Yiyuan GUO

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).