From: Hannes Reinecke <hare@suse.de>
To: Muneendra <muneendra.kumar@broadcom.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com
Subject: Re: [PATCH v8 02/16] blkcg: Added a app identifier support for blkcg
Date: Thu, 4 Mar 2021 13:25:55 +0100 [thread overview]
Message-ID: <21d35185-705f-4baa-0f43-f9d71103c7b7@suse.de> (raw)
In-Reply-To: <1614835646-16217-3-git-send-email-muneendra.kumar@broadcom.com>
On 3/4/21 6:27 AM, Muneendra wrote:
> This Patch added a unique application identifier i.e
> fc_app_id member in blkcg which allows identification of traffic
> sources at an individual cgroup based Applications
> (ex:virtual machine (VM))level in both host and
> fabric infrastructure.
>
> Added a new function blkcg_get_fc_appid to
> grab the app identifier associated with a bio.
>
> Added a new function blkcg_set_fc_appid to
> set the app identifier in a blkcgrp associated with cgroup id
>
> Added a new config BLK_CGROUP_FC_APPID and moved the changes
> under this config
>
> Signed-off-by: Muneendra <muneendra.kumar@broadcom.com>
>
> ---
> v8:
> No change
>
> v7:
> Modified the Kconfig file
>
> v6:
> Modified the Kconfig file as per standard specified
> in Documentation/process/coding-style.rst
>
> v5:
> Renamed the arguments appropriatley
> Renamed APPID_LEN to FC_APPID_LEN
> Moved the input validation at the begining of the function
> Modified the comments
>
> v4:
> No change
>
> v3:
> Renamed the functions and app_id to more specific
>
> Addressed the reference leaks in blkcg_set_app_identifier
>
> Added a new config BLK_CGROUP_FC_APPID and moved the changes
> under this config
>
> Added blkcg_get_fc_appid,blkcg_set_fc_appid as inline functions
>
> v2:
> renamed app_identifier to app_id
> removed the sysfs interface blkio.app_identifie under
> ---
> block/Kconfig | 9 ++++++
> include/linux/blk-cgroup.h | 56 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 65 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-03-04 12:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 5:27 [PATCH v8 00/16] blkcg:Support to track FC storage blk io traffic Muneendra
2021-03-04 5:27 ` [PATCH v8 01/16] cgroup: Added cgroup_get_from_id Muneendra
2021-03-04 12:25 ` Hannes Reinecke
2021-03-04 16:26 ` kernel test robot
2021-03-04 5:27 ` [PATCH v8 02/16] blkcg: Added a app identifier support for blkcg Muneendra
2021-03-04 12:25 ` Hannes Reinecke [this message]
2021-03-04 5:27 ` [PATCH v8 03/16] nvme: Added a newsysfs attribute appid_store Muneendra
2021-03-04 12:27 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 04/16] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2021-03-04 12:29 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 05/16] lpfc: vmid: Supplementary data structures for vmid and APIs Muneendra
2021-03-04 12:31 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 06/16] lpfc: vmid: Forward declarations for APIs Muneendra
2021-03-04 12:32 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 07/16] lpfc: vmid: VMID params initialization Muneendra
2021-03-04 12:33 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 08/16] lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup Muneendra
2021-03-04 12:34 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 09/16] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2021-03-04 12:36 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 10/16] lpfc: vmid: Functions to manage vmids Muneendra
2021-03-04 12:41 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 11/16] lpfc: vmid: Implements CT commands for appid Muneendra
2021-03-04 12:42 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 12/16] lpfc: vmid: Appends the vmid in the wqe before sending Muneendra
2021-03-04 12:43 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 13/16] lpfc: vmid: Timeout implementation for vmid Muneendra
2021-03-04 12:46 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 14/16] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2021-03-04 12:47 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 15/16] lpfc: vmid: Introducing vmid in io path Muneendra
2021-03-04 12:52 ` Hannes Reinecke
2021-03-04 5:27 ` [PATCH v8 16/16] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2021-03-04 12:53 ` Hannes Reinecke
2021-03-11 15:33 ` [PATCH v8 00/16] blkcg:Support to track FC storage blk io traffic Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d35185-705f-4baa-0f43-f9d71103c7b7@suse.de \
--to=hare@suse.de \
--cc=emilne@redhat.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).