From: Tony Asleson <tasleson@redhat.com>
To: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] print_req_error: Use dev_err_ratelimited
Date: Tue, 17 Nov 2020 14:41:29 -0600 [thread overview]
Message-ID: <24d6bc43-d50a-7845-6fcc-ed65b779242e@redhat.com> (raw)
In-Reply-To: <20201026160515.542586-1-tasleson@redhat.com>
Any thoughts on this?
Getting all the error paths to go through dev_printk is
quite useful.
On 10/26/20 11:05 AM, Tony Asleson wrote:
> Replace printk_ratelimited with dev_err_ratelimited which
> adds dev_printk meta data. This is used by journald to
> add disk ID information to the journal entry.
>
> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---
> block/blk-core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 10c08ac50697..ee5d63e54a11 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -216,16 +216,18 @@ EXPORT_SYMBOL_GPL(blk_status_to_errno);
> static void print_req_error(struct request *req, blk_status_t status,
> const char *caller)
> {
> + struct device *dev;
> int idx = (__force int)status;
>
> if (WARN_ON_ONCE(idx >= ARRAY_SIZE(blk_errors)))
> return;
>
> - printk_ratelimited(KERN_ERR
> - "%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
> + dev = req->rq_disk ? disk_to_dev(req->rq_disk) : NULL;
> +
> + dev_err_ratelimited(dev,
> + "%s: %s error, sector %llu op 0x%x:(%s) flags 0x%x "
> "phys_seg %u prio class %u\n",
> caller, blk_errors[idx].name,
> - req->rq_disk ? req->rq_disk->disk_name : "?",
> blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
> req->cmd_flags & ~REQ_OP_MASK,
> req->nr_phys_segments,
>
> base-commit: bbf5c979011a099af5dc76498918ed7df445635b
>
prev parent reply other threads:[~2020-11-17 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:05 [PATCH] print_req_error: Use dev_err_ratelimited Tony Asleson
2020-11-17 20:41 ` Tony Asleson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24d6bc43-d50a-7845-6fcc-ed65b779242e@redhat.com \
--to=tasleson@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).