* Stray reference to RQF_SORTED
@ 2021-02-26 9:52 Jean Delvare
2021-02-26 18:31 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2021-02-26 9:52 UTC (permalink / raw)
To: Jens Axboe; +Cc: Ming Lei, Omar Sandoval, linux-block, Hannes Reinecke
Hi Jens,
In commit a1ce35fa49852db60fc6e268038530be533c5b15 ("block: remove dead
elevator code") you removed all users of RQF_SORTED. However there is
still one reference left to it:
block/blk-mq-sched.c:412: rq->rq_flags |= RQF_SORTED;
This in effect is dead code now. Should this statement have been
removed as part of the aforementioned commit? And then maybe also the
definition of RQF_SORTED, to prevent further confusion?
Thanks,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Stray reference to RQF_SORTED
2021-02-26 9:52 Stray reference to RQF_SORTED Jean Delvare
@ 2021-02-26 18:31 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-02-26 18:31 UTC (permalink / raw)
To: Jean Delvare; +Cc: Ming Lei, Omar Sandoval, linux-block, Hannes Reinecke
On 2/26/21 2:52 AM, Jean Delvare wrote:
> Hi Jens,
>
> In commit a1ce35fa49852db60fc6e268038530be533c5b15 ("block: remove dead
> elevator code") you removed all users of RQF_SORTED. However there is
> still one reference left to it:
>
> block/blk-mq-sched.c:412: rq->rq_flags |= RQF_SORTED;
>
> This in effect is dead code now. Should this statement have been
> removed as part of the aforementioned commit? And then maybe also the
> definition of RQF_SORTED, to prevent further confusion?
It's just a leftover, feel free to send a patch to kill it.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-26 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 9:52 Stray reference to RQF_SORTED Jean Delvare
2021-02-26 18:31 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).