From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
josef@toxicpanda.com, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org
Subject: Re: [RESEND RFC PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency
Date: Mon, 30 Sep 2019 11:29:21 +0300 [thread overview]
Message-ID: <276a02f3-3b1a-0580-54fb-497f85103ae3@gmail.com> (raw)
In-Reply-To: <cover.1560510935.git.asml.silence@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1091 bytes --]
Hi,
I claim, that there is a bug, that hopefully doesn't show itself apart
from a minor disabled optimisation. It's _too_ easy to misuse, and if
somebody try to reuse, this could lead to quite interesting issues.
Could somebody at last take a look?
Thanks
On 25/07/2019 00:35, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
>
> There are implicit assumptions about struct blk_rq_stats, which make
> it's very easy to misuse. The first patch fixes consequences, and the
> second employs type-system to prevent recurrences.
>
> Acked-by: Josef Bacik <josef@toxicpanda.com>
>
> Pavel Begunkov (2):
> blk-iolatency: Fix zero mean in previous stats
> blk-stats: Introduce explicit stat staging buffers
>
> block/blk-iolatency.c | 60 ++++++++++++++++++++++++++++++---------
> block/blk-stat.c | 48 +++++++++++++++++++++++--------
> block/blk-stat.h | 9 ++++--
> include/linux/blk_types.h | 6 ++++
> 4 files changed, 94 insertions(+), 29 deletions(-)
>
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-09-30 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 11:44 [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 1/2] blk-iolatency: Fix zero mean in previous stats Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 11:47 ` [PATCH 2/2] blk-stats: Introduce explicit stat staging buffers Pavel Begunkov (Silence)
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-06-14 13:40 ` [PATCH 0/2] Fix misuse of blk_rq_stats in blk-iolatency Josef Bacik
2019-06-20 17:18 ` Pavel Begunkov
2019-06-29 15:37 ` Pavel Begunkov
2019-07-11 1:17 ` Pavel Begunkov
2019-07-24 21:35 ` [RESEND RFC PATCH " Pavel Begunkov (Silence)
2019-09-30 8:29 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276a02f3-3b1a-0580-54fb-497f85103ae3@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).