From: John Garry <john.garry@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
<linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
Wen Xiong <wenxiong@us.ibm.com>, Hannes Reinecke <hare@suse.de>,
Keith Busch <kbusch@kernel.org>, Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH V4 1/3] driver core: mark device as irq affinity managed if any irq is managed
Date: Thu, 22 Jul 2021 08:48:36 +0100 [thread overview]
Message-ID: <27cf7c97-6b03-d1fd-7bfc-6aaf3cd50272@huawei.com> (raw)
In-Reply-To: <87y29zpgct.ffs@nanos.tec.linutronix.de>
On 21/07/2021 21:22, Thomas Gleixner wrote:
>>> That's what I assumed, but this text from John suggested there is
>>> something odd about the platform case:
>>>
>>> "Did you consider that for PCI .."
>>> .
>> For this special platform MSI case there is a secondary interrupt
>> controller (called mbigen) which generates the MSI on behalf of the
>> device, which I think the MSI belongs to (and not the device, itself).
> MBIGEN is a different story because it converts wired interrupts into
> MSI interrupts, IOW a MSI based interrupt pin extender.
>
> I might be wrong, but I seriously doubt that any multiqueue device which
> wants to use affinity managed interrupts is built on top of that.
Actually the SCSI device for which platform device managed interrupts
support was added in commit e15f2fa959f2 uses mbigen.
Thanks,
John
next prev parent reply other threads:[~2021-07-22 7:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:08 [PATCH V4 0/3] blk-mq: fix blk_mq_alloc_request_hctx Ming Lei
2021-07-15 12:08 ` [PATCH V4 1/3] driver core: mark device as irq affinity managed if any irq is managed Ming Lei
2021-07-15 12:40 ` Greg Kroah-Hartman
2021-07-16 2:17 ` Ming Lei
2021-07-16 20:01 ` Bjorn Helgaas
2021-07-17 9:30 ` Ming Lei
2021-07-21 0:30 ` Bjorn Helgaas
2021-07-19 7:51 ` John Garry
2021-07-19 9:44 ` Christoph Hellwig
2021-07-19 10:39 ` John Garry
2021-07-20 2:38 ` Ming Lei
2021-07-21 7:20 ` Thomas Gleixner
2021-07-21 7:24 ` Christoph Hellwig
2021-07-21 9:44 ` John Garry
2021-07-21 20:22 ` Thomas Gleixner
2021-07-22 7:48 ` John Garry [this message]
2021-07-21 20:14 ` Thomas Gleixner
2021-07-21 20:32 ` Christoph Hellwig
2021-07-21 22:38 ` Thomas Gleixner
2021-07-22 7:46 ` Christoph Hellwig
2021-07-15 12:08 ` [PATCH V4 2/3] blk-mq: mark if one queue map uses managed irq Ming Lei
2021-07-15 12:08 ` [PATCH V4 3/3] blk-mq: don't deactivate hctx if managed irq isn't used Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27cf7c97-6b03-d1fd-7bfc-6aaf3cd50272@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).