From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB66C433DF for ; Sat, 16 May 2020 15:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF8D020767 for ; Sat, 16 May 2020 15:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DN0wCVU0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726247AbgEPPwI (ORCPT ); Sat, 16 May 2020 11:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726206AbgEPPwI (ORCPT ); Sat, 16 May 2020 11:52:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22C57C061A0C; Sat, 16 May 2020 08:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=2KbezNhRNWs5m54H7Kb2CNAyLFyIFGbIsnhHv2rt/2A=; b=DN0wCVU0GlzA09FXLFd/+SwDyY 4cZwnmrP4dPU/p8CIsss4qEMpxgAYtNPTfXwNjN/SsVCfaAD4DvdnUJX9wpxTF6Dfyqa9Rf3ZzoTn hTvewvhKagjmxXJLDI9tYv7HqKaZZO8dLD4IMlu6WDXrfXNF3yfIUR2Vo5zowKUWIEX0UG6glV284 JM63LthqER1I/74w0/BAbjkWp4Euy/Rpcx1dxuzx8Mf9hYdu+/Wkmhqo3dbD931BCbbaRd1I40Seu OnzybdY3/dJM4Cga51kf2yg9noSgCXB9mxpOLJ8HBQ2xh4Yv0H/giUsvBulloD1Oz6frcyRZPLEYG NWjVejaA==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZz6W-0001A0-Iu; Sat, 16 May 2020 15:52:00 +0000 Subject: Re: [PATCH v5 4/6] partitions/efi: Support GPT entry lookup at a non-standard location To: Dmitry Osipenko , Jens Axboe , Thierry Reding , Jonathan Hunter , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , David Heidelberg , Peter Geis , Stephen Warren , Nicolas Chauvet , Ulf Hansson , Adrian Hunter , Billy Laws , =?UTF-8?Q?Nils_=c3=96stlund?= , Christoph Hellwig , Ard Biesheuvel , Davidlohr Bueso Cc: linux-tegra@vger.kernel.org, linux-block@vger.kernel.org, Andrey Danin , Gilles Grandou , Ryan Grachek , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Steve McIntyre , linux-efi References: <20200516153644.13748-1-digetx@gmail.com> <20200516153644.13748-5-digetx@gmail.com> From: Randy Dunlap Message-ID: <2ae298ca-016a-8867-52dd-86d99b9e0f3b@infradead.org> Date: Sat, 16 May 2020 08:51:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200516153644.13748-5-digetx@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/16/20 8:36 AM, Dmitry Osipenko wrote: > diff --git a/block/partitions/efi.c b/block/partitions/efi.c > index b64bfdd4326c..3af4660bc11f 100644 > --- a/block/partitions/efi.c > +++ b/block/partitions/efi.c > @@ -621,6 +621,14 @@ static int find_valid_gpt(struct parsed_partitions *state, gpt_header **gpt, > if (!good_agpt && force_gpt) > good_agpt = is_gpt_valid(state, lastlba, &agpt, &aptes); > > + /* The force_gpt_sector is used by NVIDIA Tegra partition parser in > + * order to convey a non-standard location of the GPT entry for lookup. > + * By default force_gpt_sector is set to 0 and has no effect. > + */ Please fix the multi-line comment format as described in Documentation/process/coding-style.rst. > + if (!good_agpt && force_gpt && state->force_gpt_sector) > + good_agpt = is_gpt_valid(state, state->force_gpt_sector, > + &agpt, &aptes); > + > /* The obviously unsuccessful case */ > if (!good_pgpt && !good_agpt) > goto fail; thanks. -- ~Randy