From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <keith.busch@intel.com>,
Nitesh Shetty <nj.shetty@samsung.com>
Cc: axboe@fb.com, joshi.k@samsung.com, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] blk: optimization for classic polling
Date: Thu, 8 Feb 2018 18:03:33 +0200 [thread overview]
Message-ID: <2fa9340f-302b-1531-d51b-d4bfbdf50f86@grimberg.me> (raw)
In-Reply-To: <20180208152730.GA4906@localhost.localdomain>
> I think it'd be simpler to have blk_poll set it back to running if
> need_resched is true rather than repeat this patter across all the
> callers:
>
> ---
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index df93102e2149..40285fe1c8ad 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -3164,6 +3164,7 @@ static bool __blk_mq_poll(struct blk_mq_hw_ctx *hctx, struct request *rq)
> cpu_relax();
> }
>
> + set_current_state(TASK_RUNNING);
> return false;
> }
>
> --
Nice!
next prev parent reply other threads:[~2018-02-08 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180208143655epcas1p444bf34705526b7839a5a135f82761aad@epcas1p4.samsung.com>
2083-05-30 4:21 ` [PATCH] blk: optimization for classic polling Nitesh Shetty
2018-02-08 15:27 ` Keith Busch
2018-02-08 16:03 ` Sagi Grimberg [this message]
[not found] ` <CGME20180213082701epcas1p4d92a86f127a0918fb9d62120bd121cb6@epcas1p4.samsung.com>
[not found] ` <1518548206-4766-1-git-send-email-nj.shetty@samsung.com>
2018-02-13 14:42 ` [PATCH v2 RESENT] " Jens Axboe
2018-02-20 13:21 ` [PATCH] " Peter Zijlstra
2018-02-20 16:27 ` Keith Busch
2018-02-20 22:37 ` Jens Axboe
2018-02-21 8:32 ` Peter Zijlstra
2018-10-10 18:52 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa9340f-302b-1531-d51b-d4bfbdf50f86@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=joshi.k@samsung.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).