Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] block: only set DYING flag once in blk_cleanup_queue()
@ 2019-08-08  2:06 Dmitry Fomichev
  2019-08-08 18:10 ` Bart Van Assche
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Fomichev @ 2019-08-08  2:06 UTC (permalink / raw)
  To: linux-block, Jens Axboe; +Cc: Damien Le Moal

This commit removes the statement in blk_cleanup_queue() function that
marks the queue as dying. QUEUE_FLAG_DYING is already set inside
blk_set_queue_dying() a few lines above, no need to do it again.

No functional change.

Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 block/blk-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index d0cc6e14d2f0..0822acc423a3 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -339,7 +339,6 @@ void blk_cleanup_queue(struct request_queue *q)
 
 	blk_queue_flag_set(QUEUE_FLAG_NOMERGES, q);
 	blk_queue_flag_set(QUEUE_FLAG_NOXMERGES, q);
-	blk_queue_flag_set(QUEUE_FLAG_DYING, q);
 	mutex_unlock(&q->sysfs_lock);
 
 	/*
-- 
2.21.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: only set DYING flag once in blk_cleanup_queue()
  2019-08-08  2:06 [PATCH] block: only set DYING flag once in blk_cleanup_queue() Dmitry Fomichev
@ 2019-08-08 18:10 ` Bart Van Assche
  0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2019-08-08 18:10 UTC (permalink / raw)
  To: Dmitry Fomichev, linux-block, Jens Axboe; +Cc: Damien Le Moal

On 8/7/19 7:06 PM, Dmitry Fomichev wrote:
> This commit removes the statement in blk_cleanup_queue() function that
> marks the queue as dying. QUEUE_FLAG_DYING is already set inside
> blk_set_queue_dying() a few lines above, no need to do it again.
> 
> No functional change.
> 
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  block/blk-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index d0cc6e14d2f0..0822acc423a3 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -339,7 +339,6 @@ void blk_cleanup_queue(struct request_queue *q)
>  
>  	blk_queue_flag_set(QUEUE_FLAG_NOMERGES, q);
>  	blk_queue_flag_set(QUEUE_FLAG_NOXMERGES, q);
> -	blk_queue_flag_set(QUEUE_FLAG_DYING, q);
>  	mutex_unlock(&q->sysfs_lock);

Reviewed-by: Bart Van Assche <bvanassche@acm.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08  2:06 [PATCH] block: only set DYING flag once in blk_cleanup_queue() Dmitry Fomichev
2019-08-08 18:10 ` Bart Van Assche

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox