From: Dmitry Osipenko <digetx@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Micha?? Miros??aw <mirq-linux@rere.qmqm.pl>,
David Heidelberg <david@ixit.cz>,
Peter Geis <pgwipeout@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Rob Herring <robh+dt@kernel.org>, Ion Agorria <AG0RRIA@yahoo.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] mmc: block: Support alternative_gpt_sector() operation
Date: Wed, 18 Aug 2021 08:40:17 +0300 [thread overview]
Message-ID: <32a009f6-7357-27cc-20e3-247de6f7d786@gmail.com> (raw)
In-Reply-To: <YRyagtKThKYK+Eah@infradead.org>
18.08.2021 08:28, Christoph Hellwig пишет:
> On Wed, Aug 18, 2021 at 03:55:44AM +0300, Dmitry Osipenko wrote:
>> +static int mmc_blk_alternative_gpt_sector(struct block_device *bdev,
>> + sector_t *sector)
>> +{
>> + struct mmc_card *card = mmc_bdev_to_card(bdev);
>> +
>> + if (!card)
>> + return -ENODEV;
>> +
>> + if (!card->host->ops->alternative_gpt_sector)
>> + return -EOPNOTSUPP;
>> +
>> + return card->host->ops->alternative_gpt_sector(card, sector);
>> +}
>> +
>
>> +static struct mmc_card *mmc_bdev_to_card(struct block_device *bdev)
>> +{
>> + struct mmc_blk_data *md;
>> +
>> + if (bdev->bd_disk->fops != &mmc_bdops)
>> + return NULL;
>
> No need for this check bow that it is only called through mmc_bdops.
Alright
>> +
>> + md = mmc_blk_get(bdev->bd_disk);
>> + if (!md)
>> + return NULL;
>> +
>> + return md->queue.card;
>> +}
>
> This reference seems to never be dropped anywhere.
>
Indeed, I missed that it bumps the refcnt.
next prev parent reply other threads:[~2021-08-18 5:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 0:55 [PATCH v5 0/5] Support EFI partition on NVIDIA Tegra devices Dmitry Osipenko
2021-08-18 0:55 ` [PATCH v5 1/5] block: Add alternative_gpt_sector() operation Dmitry Osipenko
2021-08-18 5:20 ` Christoph Hellwig
2021-08-18 5:41 ` Dmitry Osipenko
2021-08-18 0:55 ` [PATCH v5 2/5] mmc: block: Support " Dmitry Osipenko
2021-08-18 5:28 ` Christoph Hellwig
2021-08-18 5:40 ` Dmitry Osipenko [this message]
2021-08-18 0:55 ` [PATCH v5 3/5] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2021-08-18 0:55 ` [PATCH v5 4/5] mmc: sdhci-tegra: Implement alternative_gpt_sector() Dmitry Osipenko
2021-08-18 5:30 ` Christoph Hellwig
2021-08-18 5:42 ` Dmitry Osipenko
2021-08-18 9:55 ` Ulf Hansson
2021-08-18 13:35 ` Thierry Reding
2021-08-18 16:15 ` Dmitry Osipenko
2021-08-19 8:58 ` Thierry Reding
2021-08-19 13:20 ` Ulf Hansson
2021-08-19 17:19 ` Thierry Reding
2021-08-20 8:16 ` Ulf Hansson
2021-08-18 0:55 ` [PATCH v5 5/5] partitions/efi: Support non-standard GPT location Dmitry Osipenko
2021-08-18 5:25 ` Christoph Hellwig
2021-08-18 5:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a009f6-7357-27cc-20e3-247de6f7d786@gmail.com \
--to=digetx@gmail.com \
--cc=AG0RRIA@yahoo.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=clamor95@gmail.com \
--cc=dave@stgolabs.net \
--cc=david@ixit.cz \
--cc=hch@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).