From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
John Garry <john.garry@huawei.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2] blk-mq: don't grab rq's refcount in blk_mq_check_expired()
Date: Tue, 17 Aug 2021 08:33:06 -0600 [thread overview]
Message-ID: <38484926-becf-4aea-8a92-5d209657722a@kernel.dk> (raw)
In-Reply-To: <20210811155202.629575-1-ming.lei@redhat.com>
On 8/11/21 9:52 AM, Ming Lei wrote:
> Inside blk_mq_queue_tag_busy_iter() we already grabbed request's
> refcount before calling ->fn(), so needn't to grab it one more time
> in blk_mq_check_expired().
>
> Meantime remove extra request expire check in blk_mq_check_expired().
Applied, thanks Ming.
--
Jens Axboe
prev parent reply other threads:[~2021-08-17 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:52 [PATCH V2] blk-mq: don't grab rq's refcount in blk_mq_check_expired() Ming Lei
2021-08-12 8:55 ` Christoph Hellwig
2021-08-12 9:40 ` John Garry
2021-08-17 1:03 ` Ming Lei
2021-08-17 14:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38484926-becf-4aea-8a92-5d209657722a@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).