From: Jens Axboe <axboe@kernel.dk>
To: Hristo Venev <hristo@venev.name>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] liburing/test: There are now 4 reserved fields
Date: Fri, 6 Sep 2019 13:24:16 -0600 [thread overview]
Message-ID: <39e068aa-5c88-c8b6-46fe-6d96f73f97b2@kernel.dk> (raw)
In-Reply-To: <20190906191252.30332-1-hristo@venev.name>
On 9/6/19 1:12 PM, Hristo Venev wrote:
> Signed-off-by: Hristo Venev <hristo@venev.name>> ---
> test/io_uring_setup.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/io_uring_setup.c b/test/io_uring_setup.c
> index 2dd3763..73b0398 100644
> --- a/test/io_uring_setup.c
> +++ b/test/io_uring_setup.c
> @@ -67,8 +67,8 @@ dump_resv(struct io_uring_params *p)
> if (!p)
> return "";
>
> - sprintf(resvstr, "0x%.8x 0x%.8x 0x%.8x 0x%.8x 0x%.8x", p->resv[0],
> - p->resv[1], p->resv[2], p->resv[3], p->resv[4]);
> + sprintf(resvstr, "0x%.8x 0x%.8x 0x%.8x 0x%.8x", p->resv[0],
> + p->resv[1], p->resv[2], p->resv[3]);
>
> return resvstr;
> }
> @@ -118,7 +118,7 @@ main(int argc, char **argv)
>
> /* resv array is non-zero */
> memset(&p, 0, sizeof(p));
> - p.resv[0] = p.resv[1] = p.resv[2] = p.resv[3] = p.resv[4] = 1;
> + p.resv[0] = p.resv[1] = p.resv[2] = p.resv[3] = 1;
> status |= try_io_uring_setup(1, &p, -1, EINVAL);
>
> /* invalid flags */
Forgot to push this one out, but I already fixed that up by adding
support for printing ->features as well.
--
Jens Axboe
prev parent reply other threads:[~2019-09-06 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 17:23 [PATCH] io_uring: allocate the two rings together Hristo Venev
2019-08-27 15:50 ` Jens Axboe
2019-08-27 19:35 ` Hristo Venev
2019-08-29 15:04 ` Jens Axboe
2019-09-06 16:26 ` Jens Axboe
2019-09-06 19:12 ` [PATCH 1/2] liburing/test: There are now 4 reserved fields Hristo Venev
2019-09-06 19:12 ` [PATCH 2/2] liburing: Use the single mmap feature Hristo Venev
2019-09-06 19:30 ` Jens Axboe
2019-09-06 19:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e068aa-5c88-c8b6-46fe-6d96f73f97b2@kernel.dk \
--to=axboe@kernel.dk \
--cc=hristo@venev.name \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).