Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.
@ 2020-06-28 13:56 Guo Xuenan
  2020-06-28 14:11 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Guo Xuenan @ 2020-06-28 13:56 UTC (permalink / raw)
  To: axboe, linux-block; +Cc: guoxuenan, wangli74, fangwei1

It is no need do finish_wait twice after acquiring inflight.

Signed-off-by: Guo Xuenan <guoxuenan@huawei.com>
---
 block/blk-rq-qos.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index 656460636ad3..18f3eab9f768 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c
@@ -273,8 +273,6 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
 		if (data.got_token)
 			break;
 		if (!has_sleeper && acquire_inflight_cb(rqw, private_data)) {
-			finish_wait(&rqw->wait, &data.wq);
-
 			/*
 			 * We raced with wbt_wake_function() getting a token,
 			 * which means we now have two. Put our local token
-- 
2.25.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.
  2020-06-28 13:56 [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait Guo Xuenan
@ 2020-06-28 14:11 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-06-28 14:11 UTC (permalink / raw)
  To: Guo Xuenan, linux-block; +Cc: wangli74, fangwei1

On 6/28/20 7:56 AM, Guo Xuenan wrote:
> It is no need do finish_wait twice after acquiring inflight.

Thanks, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28 13:56 [PATCH v2] blk-rq-qos: remove redundant finish_wait to rq_qos_wait Guo Xuenan
2020-06-28 14:11 ` Jens Axboe

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git