From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Niklas Cassel <Niklas.Cassel@wdc.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] mq-deadline: Fix request accounting
Date: Tue, 24 Aug 2021 11:09:43 -0600 [thread overview]
Message-ID: <412b4df5-aa1c-c95b-7b71-c0fc61ae3d06@kernel.dk> (raw)
In-Reply-To: <20210824170520.1659173-1-bvanassche@acm.org>
On 8/24/21 11:05 AM, Bart Van Assche wrote:
> The block layer may call the I/O scheduler .finish_request() callback
> without having called the .insert_requests() callback. Make sure that the
> mq-deadline I/O statistics are correct if the block layer inserts an I/O
> request that bypasses the I/O scheduler. This patch prevents that lower
> priority I/O is delayed longer than necessary for mixed I/O priority
> workloads.
>
> Cc: Niklas Cassel <Niklas.Cassel@wdc.com>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> Fixes: 08a9ad8bf607 ("block/mq-deadline: Add cgroup support")
This one is a little confusing, since that commit got reverted...
Yet the patch still applies.
Shouldn't it be:
Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")
--
Jens Axboe
next prev parent reply other threads:[~2021-08-24 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:05 [PATCH] mq-deadline: Fix request accounting Bart Van Assche
2021-08-24 17:09 ` Jens Axboe [this message]
2021-08-24 17:13 ` Bart Van Assche
2021-08-24 17:18 ` Jens Axboe
2021-08-24 21:35 ` Niklas Cassel
2021-08-27 2:22 ` Bart Van Assche
2021-08-27 9:20 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412b4df5-aa1c-c95b-7b71-c0fc61ae3d06@kernel.dk \
--to=axboe@kernel.dk \
--cc=Niklas.Cassel@wdc.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).