archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <>
To: Bart Van Assche <>
Cc:, Christoph Hellwig <>,
	Jaegeuk Kim <>,
	Niklas Cassel <>,
	Damien Le Moal <>,
	Hannes Reinecke <>
Subject: Re: [PATCH] mq-deadline: Fix request accounting
Date: Tue, 24 Aug 2021 11:09:43 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 8/24/21 11:05 AM, Bart Van Assche wrote:
> The block layer may call the I/O scheduler .finish_request() callback
> without having called the .insert_requests() callback. Make sure that the
> mq-deadline I/O statistics are correct if the block layer inserts an I/O
> request that bypasses the I/O scheduler. This patch prevents that lower
> priority I/O is delayed longer than necessary for mixed I/O priority
> workloads.
> Cc: Niklas Cassel <>
> Cc: Damien Le Moal <>
> Cc: Hannes Reinecke <>
> Reported-by: Niklas Cassel <>
> Fixes: 08a9ad8bf607 ("block/mq-deadline: Add cgroup support")

This one is a little confusing, since that commit got reverted...
Yet the patch still applies.

Shouldn't it be:

Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")

Jens Axboe

  reply	other threads:[~2021-08-24 17:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 17:05 [PATCH] mq-deadline: Fix request accounting Bart Van Assche
2021-08-24 17:09 ` Jens Axboe [this message]
2021-08-24 17:13   ` Bart Van Assche
2021-08-24 17:18     ` Jens Axboe
2021-08-24 21:35 ` Niklas Cassel
2021-08-27  2:22   ` Bart Van Assche
2021-08-27  9:20     ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).