From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.com>,
chenxiang <chenxiang66@hisilicon.com>,
Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>,
Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH V3] block: drain queue before waiting for q_usage_counter becoming zero
Date: Fri, 5 Jan 2018 09:10:26 -0700 [thread overview]
Message-ID: <4134703e-d732-6d13-07ab-534f44e0bbc3@kernel.dk> (raw)
In-Reply-To: <20171129235635.20292-1-ming.lei@redhat.com>
On 11/29/17 4:56 PM, Ming Lei wrote:
> Now we track legacy requests with .q_usage_counter in commit 055f6e18e08f
> ("block: Make q_usage_counter also track legacy requests"), but that
> commit never runs and drains legacy queue before waiting for this counter
> becoming zero, then IO hang is caused in the test of pulling disk during IO.
>
> This patch fixes the issue by draining requests before waiting for
> q_usage_counter becoming zero, both Mauricio and chenxiang reported this
> issue, and observed that it can be fixed by this patch.
Better late than never, added for 4.15, thanks Ming.
--
Jens Axboe
prev parent reply other threads:[~2018-01-05 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 23:56 [PATCH V3] block: drain queue before waiting for q_usage_counter becoming zero Ming Lei
2017-12-20 23:12 ` Ming Lei
2018-01-05 16:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4134703e-d732-6d13-07ab-534f44e0bbc3@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=chenxiang66@hisilicon.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=mauricfo@linux.vnet.ibm.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).