linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,
	linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org
Cc: Frank Steiner <fsteiner-mail1@bio.ifi.lmu.de>,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Jens Axboe <axboe@kernel.dk>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 1/3] block: introduce LED block device activity trigger
Date: Fri, 26 Jul 2019 23:22:10 +0200	[thread overview]
Message-ID: <44a6093f-7df7-9442-c33b-5827eb5f187b@gmail.com> (raw)
In-Reply-To: <1563807552-23498-2-git-send-email-akinobu.mita@gmail.com>

Hi Akinobu,

Thank you for the v2. I've checked and it works as expected.

One thing is missing though - ABI documentation.

Please add Documentation/ABI/testing/sysfs-class-led-trigger-blk
and document read, write and discard files.

Best regards,
Jacek Anaszewski

On 7/22/19 4:59 PM, Akinobu Mita wrote:
> This allows LEDs to be controlled by block device activity.
> 
> We already have ledtrig-disk (LED disk activity trigger), but the lower
> level disk drivers need to utilize ledtrig_disk_activity() to make the
> LED blink.
> 
> The LED block device trigger doesn't require the lower level drivers to
> have any instrumentation. The activity is collected by polling the disk
> stats.
> 
> Example:
> 
> echo block-nvme0n1 > /sys/class/leds/diy/trigger
> 
> Cc: Frank Steiner <fsteiner-mail1@bio.ifi.lmu.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
>  block/genhd.c                      |   2 +
>  drivers/leds/trigger/Kconfig       |   7 ++
>  drivers/leds/trigger/Makefile      |   1 +
>  drivers/leds/trigger/ledtrig-blk.c | 225 +++++++++++++++++++++++++++++++++++++
>  include/linux/genhd.h              |   3 +
>  include/linux/leds.h               |  27 +++++
>  6 files changed, 265 insertions(+)
>  create mode 100644 drivers/leds/trigger/ledtrig-blk.c
[...]

  parent reply	other threads:[~2019-07-26 21:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:59 [PATCH v2 0/3] introduce LED block device activity trigger Akinobu Mita
2019-07-22 14:59 ` [PATCH v2 1/3] block: " Akinobu Mita
2019-07-23  2:04   ` kbuild test robot
2019-07-23 15:26     ` Akinobu Mita
2019-07-23  2:22   ` kbuild test robot
2019-07-23 15:28     ` Akinobu Mita
2019-07-26 21:22   ` Jacek Anaszewski [this message]
2019-07-28 13:51     ` Akinobu Mita
2019-07-28 17:46       ` Jacek Anaszewski
2019-07-22 14:59 ` [PATCH v2 2/3] ledtrig-blk: add interface to stop and restart polling disk stats Akinobu Mita
2019-07-22 14:59 ` [PATCH v2 3/3] scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspend Akinobu Mita
2019-08-10 15:41 ` [PATCH v2 0/3] introduce LED block device activity trigger Frank Steiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44a6093f-7df7-9442-c33b-5827eb5f187b@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=akinobu.mita@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dmurphy@ti.com \
    --cc=fsteiner-mail1@bio.ifi.lmu.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).