From: "Chris Murphy" <lists@colorremedies.com>
To: "Jens Axboe" <axboe@kernel.dk>, "Jan Kara" <jack@suse.cz>,
"Paolo Valente" <paolo.valente@linaro.org>
Cc: "Btrfs BTRFS" <linux-btrfs@vger.kernel.org>,
Linux-RAID <linux-raid@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Josef Bacik" <josef@toxicpanda.com>
Subject: Re: stalling IO regression since linux 5.12, through 5.18
Date: Tue, 16 Aug 2022 10:22:41 -0400 [thread overview]
Message-ID: <4995baed-c561-421d-ba3e-3a75d6a738a3@www.fastmail.com> (raw)
In-Reply-To: <61e5ccda-a527-4fea-9850-91095ffa91c4@www.fastmail.com>
On Sun, Aug 14, 2022, at 4:28 PM, Chris Murphy wrote:
> On Fri, Aug 12, 2022, at 2:02 PM, Jens Axboe wrote:
>> Might be worth trying to revert those from 5.12 to see if they are
>> causing the issue? Jan, Paolo - does this ring any bells?
>
> git log --oneline --no-merges v5.11..c03c21ba6f4e > bisect.txt
>
> I tried checking out a33df75c6328, which is right before the first bfq
> commit, but that kernel won't boot the hardware.
>
> Next I checked out v5.12, then reverted these commits in order (that
> they were found in the bisect.txt file):
>
> 7684fbde4516 bfq: Use only idle IO periods for think time calculations
> 28c6def00919 bfq: Use 'ttime' local variable
> 41e76c85660c bfq: Avoid false bfq queue merging
>>>>a5bf0a92e1b8 bfq: bfq_check_waker() should be static
> 71217df39dc6 block, bfq: make waker-queue detection more robust
> 5a5436b98d5c block, bfq: save also injection state on queue merging
> e673914d52f9 block, bfq: save also weight-raised service on queue merging
> d1f600fa4732 block, bfq: fix switch back from soft-rt weitgh-raising
> 7f1995c27b19 block, bfq: re-evaluate convenience of I/O plugging on rq arrivals
> eb2fd80f9d2c block, bfq: replace mechanism for evaluating I/O intensity
>>>>1a23e06cdab2 bfq: don't duplicate code for different paths
> 2391d13ed484 block, bfq: do not expire a queue when it is the only busy
> one
> 3c337690d2eb block, bfq: avoid spurious switches to soft_rt of
> interactive queues
> 91b896f65d32 block, bfq: do not raise non-default weights
> ab1fb47e33dc block, bfq: increase time window for waker detection
> d4fc3640ff36 block, bfq: set next_rq to waker_bfqq->next_rq in waker
> injection
> b5f74ecacc31 block, bfq: use half slice_idle as a threshold to check
> short ttime
>
> The two commits prefixed by >>> above were not previously mentioned by
> Jens, but I reverted them anyway because they showed up in the git log
> command.
>
> OK so, within 10 minutes the problem does happen still. This is
> block/bfq-iosched.c resulting from the above reverts, in case anyone
> wants to double check what I did:
> https://drive.google.com/file/d/1ykU7MpmylJuXVobODWiiaLJk-XOiAjSt/view?usp=sharing
Any suggestions for further testing? I could try go down farther in the bisect.txt list. The problem is if the hardware falls over on an unbootable kernel, I have to bug someone with LOM access. That's a limited resource.
--
Chris Murphy
next prev parent reply other threads:[~2022-08-16 14:23 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 16:35 stalling IO regression in linux 5.12 Chris Murphy
2022-08-10 17:48 ` Josef Bacik
2022-08-10 18:33 ` Chris Murphy
2022-08-10 18:42 ` Chris Murphy
2022-08-10 19:31 ` Josef Bacik
2022-08-10 19:34 ` Chris Murphy
2022-08-12 16:05 ` stalling IO regression since linux 5.12, through 5.18 Chris Murphy
2022-08-12 17:59 ` Josef Bacik
2022-08-12 18:02 ` Jens Axboe
2022-08-14 20:28 ` Chris Murphy
2022-08-16 14:22 ` Chris Murphy [this message]
2022-08-16 15:25 ` Nikolay Borisov
2022-08-16 15:34 ` Chris Murphy
2022-08-17 9:52 ` Holger Hoffstätte
2022-08-17 11:49 ` Jan Kara
2022-08-17 14:37 ` Chris Murphy
2022-08-17 15:09 ` Chris Murphy
2022-08-17 16:30 ` Jan Kara
2022-08-17 16:47 ` Chris Murphy
2022-08-17 17:57 ` Chris Murphy
2022-08-17 18:15 ` Jan Kara
2022-08-17 18:18 ` Chris Murphy
2022-08-17 18:33 ` Jan Kara
2022-08-17 18:54 ` Chris Murphy
2022-08-17 19:23 ` Chris Murphy
2022-08-18 2:31 ` Chris Murphy
2022-08-17 18:21 ` Holger Hoffstätte
2022-08-17 11:57 ` Chris Murphy
2022-08-17 12:31 ` Holger Hoffstätte
2022-08-17 18:16 ` Chris Murphy
2022-08-17 18:38 ` Holger Hoffstätte
2022-08-17 12:06 ` Ming Lei
2022-08-17 14:34 ` Chris Murphy
2022-08-17 14:53 ` Ming Lei
2022-08-17 15:02 ` Chris Murphy
2022-08-17 15:34 ` Ming Lei
2022-08-17 16:34 ` Chris Murphy
2022-08-18 1:03 ` Ming Lei
2022-08-18 2:30 ` Chris Murphy
2022-08-18 3:24 ` Ming Lei
2022-08-18 4:12 ` Chris Murphy
2022-08-18 4:18 ` Chris Murphy
2022-08-18 4:27 ` Chris Murphy
2022-08-18 4:32 ` Chris Murphy
2022-08-18 5:15 ` Ming Lei
2022-08-18 18:52 ` Chris Murphy
2022-08-18 5:24 ` Ming Lei
2022-08-18 13:50 ` Chris Murphy
2022-08-18 15:10 ` Ming Lei
2022-08-19 19:20 ` Chris Murphy
2022-08-20 7:00 ` Ming Lei
2022-09-01 7:02 ` Yu Kuai
2022-09-01 8:03 ` Jan Kara
2022-09-01 8:19 ` Yu Kuai
2022-09-06 9:49 ` Paolo Valente
2022-09-02 16:53 ` Chris Murphy
2022-09-06 9:45 ` Paolo Valente
2022-08-15 11:25 ` stalling IO regression in linux 5.12 Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995baed-c561-421d-ba3e-3a75d6a738a3@www.fastmail.com \
--to=lists@colorremedies.com \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).