From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][for-linus] io_uring: Fix leaked shadow_req
Date: Sun, 27 Oct 2019 21:29:45 -0600 [thread overview]
Message-ID: <4b46e7b1-0719-d88f-175f-c9fdee224b38@kernel.dk> (raw)
In-Reply-To: <47835fb780667714ba2d21e9a00fe69bc9bbef47.1572203348.git.asml.silence@gmail.com>
On 10/27/19 1:10 PM, Pavel Begunkov wrote:
> io_queue_link_head() owns shadow_req after taking it as an argument.
> By not freeing it in case of an error, it can leak the request along
> with taken ctx->refs.
Thakns, applied.
--
Jens Axboe
prev parent reply other threads:[~2019-10-28 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 19:10 [PATCH][for-linus] io_uring: Fix leaked shadow_req Pavel Begunkov
2019-10-28 3:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b46e7b1-0719-d88f-175f-c9fdee224b38@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).