archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <>
To: Jens Axboe <>,
	Damien Le Moal <>,,,
	"Martin K . Petersen" <>,
Subject: Re: [PATCH v7 1/5] block: Add independent access ranges support
Date: Tue, 7 Sep 2021 07:31:21 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 2021/09/07 2:38, Jens Axboe wrote:
> On 9/5/21 7:58 PM, Damien Le Moal wrote:
>> struct blk_independent_access_ranges contains kobjects (struct kobject)
>> to expose to the user through sysfs the set of independent access ranges
>> supported by a device. When the device is initialized, sysfs
>> registration of the ranges information is done from blk_register_queue()
>> using the block layer internal function disk_register_iaranges(). If a
>> driver calls disk_set_iaranges() for a registered queue, e.g. when a
>> device is revalidated, disk_set_iaranges() will execute
>> disk_register_iaranges() to update the sysfs attribute files.
> I really detest the iaranges "name", it's horribly illegible. If you
> want to stick with the ia thing, then disk_register_ia_ranges() would be
> a lot better (though still horrible, imho, just less so).

For the function names, similarly with the struct names, I can use the full
spelling, so disk_set_independent_access_ranges() and
disk_alloc_independent_access_ranges(). Same for the internal functions for
sysfs registration. Longer function names, but very clear I think.

> Same goes for blk-iaranges, we really need to come up with something
> more descriptive here.

OK. I can rename the file to block/blk-independent-access-ranges.c. It is a long
but clear. Are you OK with shortened local variable names in that file ? Using
the full spelling make formatting of the code really hard due to the very long

Damien Le Moal
Western Digital Research

  reply	other threads:[~2021-09-06 22:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  1:58 [PATCH v7 0/5] Initial support for multi-actuator HDDs Damien Le Moal
2021-09-06  1:58 ` [PATCH v7 1/5] block: Add independent access ranges support Damien Le Moal
2021-09-06  8:14   ` Hannes Reinecke
2021-09-06 17:38   ` Jens Axboe
2021-09-06 22:31     ` Damien Le Moal [this message]
2021-09-06  1:58 ` [PATCH v7 2/5] scsi: sd: add concurrent positioning " Damien Le Moal
2021-09-06  8:35   ` Hannes Reinecke
2021-09-06  1:58 ` [PATCH v7 3/5] libata: support concurrent positioning ranges log Damien Le Moal
2021-09-06  1:58 ` [PATCH v7 4/5] doc: document sysfs queue/independent_access_ranges attributes Damien Le Moal
2021-09-06  8:37   ` Hannes Reinecke
2021-09-06  1:58 ` [PATCH v7 5/5] doc: Fix typo in request queue sysfs documentation Damien Le Moal
2021-09-06  8:37   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).