linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] Add arm64 memory barriers support
Date: Thu, 8 Aug 2019 20:37:31 -0700	[thread overview]
Message-ID: <4c34db65-26aa-31c5-b255-595de70b43bd@kernel.dk> (raw)
In-Reply-To: <1565318439-13992-1-git-send-email-liuyun01@kylinos.cn>

On 8/8/19 7:40 PM, Jackie Liu wrote:
> making liburing on arm64 platform failed. let's support it.
> 
> root@Kylin:/# cat /etc/os-release
> PRETTY_NAME="Debian GNU/Linux buster/sid"
> 
> root@Kylin:/# gcc -v
> gcc version 8.2.0 (Debian 8.2.0-20)
> 
> root@Kylin:~/liburing# make
> make[1]: Entering directory '/root/liburing/src'
> cc -g -fomit-frame-pointer -O2 -Wall -Iinclude/ -c -o setup.ol setup.c
> In file included from include/liburing.h:14,
>                   from setup.c:10:
> include/liburing.h: In function 'io_uring_cq_advance':
> include/liburing/barrier.h:73:2: warning: implicit declaration of function 'smp_mb'; did you mean 'smp_wmb'? [-Wimplicit-function-declaration]
>    smp_mb();    \
>    ^~~~~~
> include/liburing.h:111:3: note: in expansion of macro 'smp_store_release'
>     smp_store_release(cq->khead, *cq->khead + nr);
>     ^~~~~~~~~~~~~~~~~

Applied, thanks.

-- 
Jens Axboe


      reply	other threads:[~2019-08-09  3:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  2:40 [PATCH] Add arm64 memory barriers support Jackie Liu
2019-08-09  3:37 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c34db65-26aa-31c5-b255-595de70b43bd@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=liuyun01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).