* Re: [PATCH] remove the lightnvm subsystem
[not found] ` <094e8eec-affe-81ba-908e-fbbe2fb7fa84@lightnvm.io>
@ 2021-08-14 19:30 ` Jens Axboe
2021-08-14 20:42 ` Javier González
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2021-08-14 19:30 UTC (permalink / raw)
To: Matias Bjørling, Christoph Hellwig, javier; +Cc: linux-nvme, linux-block
On 8/14/21 1:01 PM, Matias Bjørling wrote:
> Thanks, Christoph.
>
> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>
> Javier, if you agree to the removal of the subsystem, would you like to
> provide your reviewed-by as well? Thanks!
Side bar - please don't quote 400k of text, this reply really didn't
need any of it.
Pet peeve of mine, and it happens way too often on reviews as well.
Don't quote the whole email just to add Reviewed/Acked-by, it's just
wasteful.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove the lightnvm subsystem
2021-08-14 19:30 ` [PATCH] remove the lightnvm subsystem Jens Axboe
@ 2021-08-14 20:42 ` Javier González
2021-08-14 21:55 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Javier González @ 2021-08-14 20:42 UTC (permalink / raw)
To: Jens Axboe
Cc: Matias Bjørling, Christoph Hellwig, linux-nvme, linux-block
> On 14 Aug 2021, at 21.30, Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/14/21 1:01 PM, Matias Bjørling wrote:
>> Thanks, Christoph.
>>
>> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>>
>> Javier, if you agree to the removal of the subsystem, would you like to
>> provide your reviewed-by as well? Thanks!
>
> Side bar - please don't quote 400k of text, this reply really didn't
> need any of it.
>
> Pet peeve of mine, and it happens way too often on reviews as well.
> Don't quote the whole email just to add Reviewed/Acked-by, it's just
> wasteful.
>
> --
> Jens Axboe
Looks good to me.
Reviewed-by: Javier González <javier@javigon.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove the lightnvm subsystem
2021-08-14 20:42 ` Javier González
@ 2021-08-14 21:55 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-08-14 21:55 UTC (permalink / raw)
To: Javier González
Cc: Matias Bjørling, Christoph Hellwig, linux-nvme, linux-block
On 8/14/21 2:42 PM, Javier González wrote:
>
>> On 14 Aug 2021, at 21.30, Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/14/21 1:01 PM, Matias Bjørling wrote:
>>> Thanks, Christoph.
>>>
>>> Reviewed-by: Matias Bjørling <mb@lightnvm.io>
>>>
>>> Javier, if you agree to the removal of the subsystem, would you like to
>>> provide your reviewed-by as well? Thanks!
>>
>> Side bar - please don't quote 400k of text, this reply really didn't
>> need any of it.
>>
>> Pet peeve of mine, and it happens way too often on reviews as well.
>> Don't quote the whole email just to add Reviewed/Acked-by, it's just
>> wasteful.
>>
>> --
>> Jens Axboe
>
> Looks good to me.
>
> Reviewed-by: Javier González <javier@javigon.com>
Thanks, applied.
Christoph, looks like at least the NVME_NS_* enums can go as well.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-14 21:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210812132308.38486-1-hch@lst.de>
[not found] ` <094e8eec-affe-81ba-908e-fbbe2fb7fa84@lightnvm.io>
2021-08-14 19:30 ` [PATCH] remove the lightnvm subsystem Jens Axboe
2021-08-14 20:42 ` Javier González
2021-08-14 21:55 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).