From: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 2/9] block: assert the locking state in delete_partition
Date: Thu, 22 Jul 2021 11:38:21 -0700 [thread overview]
Message-ID: <4d9b4e2a-12d3-7561-e407-975e62cea53e@gmail.com> (raw)
In-Reply-To: <20210722075402.983367-3-hch@lst.de>
On 7/22/2021 12:53 AM, Christoph Hellwig wrote:
> Add a lockdep assert instead of the outdated locking comment.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> ---
> block/partitions/core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index 4230d4f71879..9902b1635b7d 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -281,12 +281,10 @@ struct device_type part_type = {
> .uevent = part_uevent,
> };
>
> -/*
> - * Must be called either with open_mutex held, before a disk can be opened or
> - * after all disk users are gone.
> - */
> static void delete_partition(struct block_device *part)
> {
> + lockdep_assert_held(&part->bd_disk->open_mutex);
> +
> fsync_bdev(part);
> __invalidate_device(part, true);
>
>
Reviewed-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
--
-ck
next prev parent reply other threads:[~2021-07-22 18:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:53 fixes and cleanups for block_device refcounting v2 Christoph Hellwig
2021-07-22 7:53 ` [PATCH 1/9] block: delay freeing the gendisk Christoph Hellwig
2021-07-22 7:53 ` [PATCH 2/9] block: assert the locking state in delete_partition Christoph Hellwig
2021-07-22 18:38 ` Chaitanya Kulkarni [this message]
2021-07-22 7:53 ` [PATCH 3/9] block: unhash the whole device inode earlier Christoph Hellwig
2021-07-22 8:19 ` Ming Lei
2021-07-22 13:12 ` Christoph Hellwig
2021-07-22 7:53 ` [PATCH 4/9] block: allocate bd_meta_info later in add_partitions Christoph Hellwig
2021-07-22 8:32 ` Ming Lei
2021-07-22 7:53 ` [PATCH 5/9] block: change the refcounting for partitions Christoph Hellwig
2021-07-22 8:41 ` Ming Lei
2021-07-22 13:12 ` Christoph Hellwig
2021-07-22 7:53 ` [PATCH 6/9] btrfs: store a block_device in struct btrfs_ordered_extent Christoph Hellwig
2021-07-22 12:58 ` David Sterba
2021-07-22 13:04 ` Christoph Hellwig
2021-07-22 7:54 ` [PATCH 7/9] loop: don't grab a reference to the block device Christoph Hellwig
2021-07-22 8:57 ` Ming Lei
2021-07-22 18:40 ` Chaitanya Kulkarni
2021-07-22 7:54 ` [PATCH 8/9] block: remove bdgrab Christoph Hellwig
2021-07-22 7:54 ` [PATCH 9/9] block: remove bdput Christoph Hellwig
2021-07-22 18:40 ` Chaitanya Kulkarni
2021-07-28 1:39 ` fixes and cleanups for block_device refcounting v2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9b4e2a-12d3-7561-e407-975e62cea53e@gmail.com \
--to=ckulkarnilinux@gmail.com \
--cc=axboe@kernel.dk \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).