linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Bart Van Assche <bvanassche@acm.org>,
	linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH] blk-mq: Use helpers to access rq->state
Date: Tue, 31 Aug 2021 09:42:27 +0300	[thread overview]
Message-ID: <4ec372d9-a234-8208-b8e3-e545d6658bd2@suse.com> (raw)
In-Reply-To: <36615406-97c4-5273-364b-8f2b5b1fb35f@acm.org>



On 30.08.21 г. 20:29, Bart Van Assche wrote:
<snip>

> Is the above patch complete? I think even with the above patch applied
> there are still two functions in the block layer that use WRITE_ONCE() to
> modify rq->state directly:
> 
> $ git grep -nH 'WRITE_ONCE(rq->state,'
> block/blk-mq.c:532:    WRITE_ONCE(rq->state, MQ_RQ_IDLE);
> block/blk-mq.c:648:    WRITE_ONCE(rq->state, MQ_RQ_COMPLETE);
> block/blk-mq.c:728:    WRITE_ONCE(rq->state, MQ_RQ_IN_FLIGHT);
> block/blk-mq.c:747:        WRITE_ONCE(rq->state, MQ_RQ_IDLE);
> block/blk-mq.c:2416:    WRITE_ONCE(rq->state, MQ_RQ_IDLE);
> include/linux/blk-mq.h:521:    WRITE_ONCE(rq->state, MQ_RQ_COMPLETE);

On just-updated master I get:

$ git grep 'WRITE_ONCE(rq->state,'
block/blk-mq.c: WRITE_ONCE(rq->state, MQ_RQ_IDLE);
block/blk-mq.c: WRITE_ONCE(rq->state, MQ_RQ_IN_FLIGHT);
block/blk-mq.c:         WRITE_ONCE(rq->state, MQ_RQ_IDLE);
block/blk-mq.c: WRITE_ONCE(rq->state, MQ_RQ_IDLE);
include/linux/blk-mq.h: WRITE_ONCE(rq->state, MQ_RQ_COMPLETE);


> 
> Thanks,
> 
> Bart.
> 

      reply	other threads:[~2021-08-31  6:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  9:50 [PATCH] blk-mq: Use helpers to access rq->state Nikolay Borisov
2021-05-12 15:24 ` Hannes Reinecke
2021-05-12 20:01 ` Chaitanya Kulkarni
2021-08-30 14:24 ` Nikolay Borisov
2021-08-30 17:29 ` Bart Van Assche
2021-08-31  6:42   ` Nikolay Borisov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec372d9-a234-8208-b8e3-e545d6658bd2@suse.com \
    --to=nborisov@suse.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).