From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A63C433B4 for ; Mon, 3 May 2021 23:40:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 542CE61183 for ; Mon, 3 May 2021 23:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbhECXlB (ORCPT ); Mon, 3 May 2021 19:41:01 -0400 Received: from mail-eopbgr760050.outbound.protection.outlook.com ([40.107.76.50]:4098 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229570AbhECXlA (ORCPT ); Mon, 3 May 2021 19:41:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hdRvlycAt8Qo9tsgR8vef7Tuf7J7QeDVYA3QcJDR7vCG0/NkdIPEBTDawYII5CWEk9+fe9X6VQ7qdvy79PWDJ1Od5nDljfB6dt7LXw0cIH17JP9v+3gI0mklpER538k/TLpJPjAUdioIMOmMvxWE7TmNEpvhFArYTSm1kCe1+ai84UoZlF0FMoUbG4+au4vyfjtQczsp8rWpzf3zkSbqkfxx9hJcNJw4pQ/J4Whq1AOr7seU0wIqJPQMcIGOZzi6vdVxZhlmLJcAgcN3DgrEVzvlojEjUmfRGhKJOMlX6BBg9k05aHGl6HZBW9Gd9OIZxI/LnZGGiOpBs4fid579/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2/v8sQ+foN7EfgbXRGyO4z/DRjMsu88P/bA8qiPNSQ=; b=PBeKoXypR9g9CiFUHLTy2tsyahjMRaQZn6H0/Z85hRofcPnQYMKaW6naNMLzFCdbu0fSIGbce/42euX1Qv0/bWUM85r34foR5jXYLdpAEQBZ2LdlzzMrBezq+7UfYkGuriVovQTkTQVR826Opzptd6Vi1yszQVnJKTdGm/o5z4ICCkzA83Jfz7DHruibyQJaRG9MhfCAIWXnEw5zFvCIu4WNr0go6WkrVtEbTR9YS0gKw7Xv/nSrkGk/boTpN1Bg7Gm+8/DUgj5pEdPw5qGCpfmlXBh//OqQYqn5oNEvzLcW/+vypW1fQyz0025uQxpXhjapm84YoXMSxMwHPIcCoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=lists.linux-foundation.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2/v8sQ+foN7EfgbXRGyO4z/DRjMsu88P/bA8qiPNSQ=; b=dt7H9XSKBav97EJaF5Zc+JDm3Vd4x8Ct1AIT6fpzLcxx4ieo+ukqGKNPX0bxoC7C3UXMCpZ1n2bOP7A4wIo8f+oHItWTdcWcK46O2VtrzDfHz3v+uXCI5Ewdp5l/5zEXAPoJIPWk/fN8kr+k8jedYZ653w5/MphKjpMZW3bCsBFaJygSBEvx7bZoljoN8E1Io4yNT5j0rFk/Wz/mNM1IqgrgXe1+DxsB6YvWJPE3hl3sQP3GcivA7uK7ByWpC11IXfOAHD4Ol2g+x74sRnvOSlb6tirej5bUT15UX2H7EaW6XoqJUO6y9/hVLwLJDf082xPNuglhOecfgq/IUpkvJA== Received: from BN8PR04CA0034.namprd04.prod.outlook.com (2603:10b6:408:70::47) by BYAPR12MB4629.namprd12.prod.outlook.com (2603:10b6:a03:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.39; Mon, 3 May 2021 23:40:05 +0000 Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:70:cafe::5f) by BN8PR04CA0034.outlook.office365.com (2603:10b6:408:70::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Mon, 3 May 2021 23:40:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4087.27 via Frontend Transport; Mon, 3 May 2021 23:40:03 +0000 Received: from [10.2.50.162] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 May 2021 23:40:03 +0000 Subject: Re: [PATCH 04/16] PCI/P2PDMA: Refactor pci_p2pdma_map_type() to take pagmap and device To: Jason Gunthorpe CC: Logan Gunthorpe , , , , , , , Stephen Bates , Christoph Hellwig , Dan Williams , =?UTF-8?Q?Christian_K=c3=b6nig?= , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy References: <20210408170123.8788-1-logang@deltatee.com> <20210408170123.8788-5-logang@deltatee.com> <20210503225705.GA2047089@ziepe.ca> From: John Hubbard Message-ID: <4fd9381a-d9aa-31fe-c1d8-660e2dbaab62@nvidia.com> Date: Mon, 3 May 2021 16:40:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210503225705.GA2047089@ziepe.ca> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: deea838f-aa53-493e-1b57-08d90e8cc6a1 X-MS-TrafficTypeDiagnostic: BYAPR12MB4629: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lWIvGhcUDMoJJKp8U0LDpIZvWFN3xY3S3rTHkvXU9sHi4uPyibrkvRYXFkHIuFa5pX7tZ/PXuz5WGSZSnogLfpgE/qYVAiVU/LrfWBLKEqMh5XU0RfxLJzyLUEE3n3cZCPjxo1Gd4LmRi3mggwEb2l6Sle7BaWOnYDqB9d0SKvxGFlgAIV3/vkozHY8NLjsxtren4qmfUxerJT1T2eKR7mdZ+1S+tZcA/a/xk24WKwXNaD0dPLSwcgc4SNYE/9Ccs6ujtpop/BUFqmzgeTcmaTgK/g7dGO9N9WXZbVd/LRH2GG/Eg71gJrymKk0Mn1Dlb9raIO1lN/FcCpbDEcdGPYF+MsUp576O/G/VFmBb562ELt6b4nQCSbWs5ywp1YjH+XOCQwVs2jA5vVEqJ/YFcK4sExgtaqqo12fanwnPMXjxPPhh/25ZIrphTrXvfOOkK1+iXiJHkymBJ9ac5N1P4WdQAAajXumriIXE8pe+U30C8kw/Rw/jYweLZNTnHw9OtvgHCYMKRBsm5IzXfmcPwR6alZu7cl9P7B2KxPLmgj/3f6GY+WMLmec38rl4RuztqDVxcU+nlMHv8s0C2zXIe1oM9OdbOu5rfSV+whdgit7IPlj8IsYgtklAEGJpYuDLzy/e5kEjYGs2MrUuvVzURtxx0JQiq9pmyOrVLd4QaST8k7JRZVWq92Q9aSoJJHsP X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(46966006)(36840700001)(54906003)(31686004)(86362001)(316002)(7416002)(82310400003)(6916009)(36906005)(31696002)(16576012)(70206006)(70586007)(2616005)(16526019)(26005)(4326008)(36860700001)(336012)(186003)(5660300002)(4744005)(426003)(8936002)(36756003)(356005)(47076005)(478600001)(53546011)(8676002)(7636003)(82740400003)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2021 23:40:03.8504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: deea838f-aa53-493e-1b57-08d90e8cc6a1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4629 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 5/3/21 3:57 PM, Jason Gunthorpe wrote: > On Mon, May 03, 2021 at 02:54:26PM -0700, John Hubbard wrote: > >> I guess my main concern here is that there are these pci*() functions >> that somehow want to pass around struct device. > > Well, this is the main issue - helpers being used inside IOMMU code > should not be called pci* functions. This is some generic device p2p > interface that happens to only support PCI to PCI transfers today. > Yes, maybe renaming a few levels of functions would help at least clarify what the code can do. Once the code reaches layers that truly are PCI-specific, that's where it should transition to using pci_dev args, and that's also where it should return -ENOTSUPP back up the calling stack. thanks, -- John Hubbard NVIDIA