From: "zhangxiaoxu (A)" <zhangxiaoxu5@huawei.com>
To: Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
John Dorminy <jdorminy@redhat.com>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>, <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: block: Fix a WRITE SAME BUG_ON
Date: Wed, 30 Jan 2019 14:50:32 +0800 [thread overview]
Message-ID: <5466ca60-0fe0-8833-6029-1e5b54dd29b4@huawei.com> (raw)
In-Reply-To: <20190129085226.GA25610@infradead.org>
On 1/29/2019 4:52 PM, Christoph Hellwig wrote:
> On Mon, Jan 28, 2019 at 11:54:08PM -0500, Martin K. Petersen wrote:
>> That said, now that we have REQ_OP_WRITE_ZEROES (where the LBS is
>> irrelevant due to the payload being the ZERO_PAGE), it may be worthwhile
>> to remove REQ_OP_WRITE_SAME. I think drbd is the only user relying on a
>> non-zero payload. The target code ends up manually iterating, if I
>> remember correctly...
>
> I had a series to remove it a while ago, but you wanted to keep it at
> that point. I can resurrect it.
>
Do you mean to remove the `blkdev_issue_write_same` interface?
I think we should fix the problem first because other users may also encounter
the same problem.
> .
>
next prev parent reply other threads:[~2019-01-30 6:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190125021107.4595-1-zhangxiaoxu5@huawei.com>
2019-01-26 11:17 ` [dm-devel] [v2] block: Fix a WRITE SAME BUG_ON John Dorminy
2019-01-28 5:48 ` zhangxiaoxu (A)
2019-01-28 22:14 ` Mike Snitzer
2019-01-29 4:54 ` Martin K. Petersen
2019-01-29 8:52 ` Christoph Hellwig
2019-01-30 6:50 ` zhangxiaoxu (A) [this message]
2019-01-30 14:08 ` John Dorminy
2019-01-31 0:58 ` zhangxiaoxu (A)
2019-01-31 2:23 ` Martin K. Petersen
2019-01-31 10:39 ` Christoph Hellwig
2019-01-31 19:41 ` John Dorminy
2019-02-01 7:35 ` Christoph Hellwig
2019-02-01 14:09 ` John Dorminy
2019-02-01 16:03 ` [dm-devel] " Heinz Mauelshagen
2019-02-01 16:18 ` Christoph Hellwig
2019-02-12 3:11 ` zhangxiaoxu (A)
2019-02-14 2:31 ` Martin K. Petersen
2019-02-14 9:36 ` zhangxiaoxu (A)
2019-02-18 14:10 ` zhangxiaoxu (A)
2019-02-19 23:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5466ca60-0fe0-8833-6029-1e5b54dd29b4@huawei.com \
--to=zhangxiaoxu5@huawei.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jdorminy@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).