From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Eric Biggers <ebiggers@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Satya Tangirala <satyaprateek2357@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/4] blk-crypto-fallback: properly prefix function and struct names
Date: Thu, 16 Sep 2021 23:07:39 +0000 [thread overview]
Message-ID: <550c2308-ed18-93a1-9f35-10ef037b25b1@nvidia.com> (raw)
In-Reply-To: <20210916172249.45813-2-ebiggers@kernel.org>
On 9/16/21 10:22 AM, Eric Biggers wrote:
> External email: Use caution opening links or attachments
>
>
> From: Eric Biggers <ebiggers@google.com>
>
> For clarity, avoid using just the "blk_crypto_" prefix for functions and
> structs that are specific to blk-crypto-fallback. Instead, use
> "blk_crypto_fallback_". Some places already did this, but others
> didn't.
>
> This is also a prerequisite for using "struct blk_crypto_keyslot" to
> mean a generic blk-crypto keyslot (which is what it sounds like).
> Rename the fallback one to "struct blk_crypto_fallback_keyslot".
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good, it might be useful to mention this patch doesn't change
any functionality, not a hard requirement though.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2021-09-16 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 17:22 [PATCH v2 0/4] blk-crypto cleanups Eric Biggers
2021-09-16 17:22 ` [PATCH v2 1/4] blk-crypto-fallback: properly prefix function and struct names Eric Biggers
2021-09-16 23:07 ` Chaitanya Kulkarni [this message]
2021-09-16 17:22 ` [PATCH v2 2/4] blk-crypto: rename keyslot-manager files to blk-crypto-profile Eric Biggers
2021-09-16 17:22 ` [PATCH v2 3/4] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Eric Biggers
2021-09-16 17:22 ` [PATCH v2 4/4] blk-crypto: update inline encryption documentation Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550c2308-ed18-93a1-9f35-10ef037b25b1@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=dm-devel@redhat.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyaprateek2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).