From: Anand Jain <anand.jain@oracle.com>
To: Josef Bacik <josef@toxicpanda.com>, linux-btrfs@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH RFC 1/7] block: export part_stat_read_all
Date: Wed, 28 Oct 2020 16:26:57 +0800 [thread overview]
Message-ID: <551a851b-fbaf-3173-09a5-8cbd92b2e7a2@oracle.com> (raw)
In-Reply-To: <5c772e21-a401-1198-29d0-7ce0278b1544@toxicpanda.com>
On 28/10/20 2:09 am, Josef Bacik wrote:
> On 10/26/20 7:55 PM, Anand Jain wrote:
>> For mirrored raid profiles such as raid1, raid1c3, raid1c4, and raid10,
>> currently, btrfs use the PID method to determine which one of the
>> mirrored devices to use to read the block. However, the PID method is
>> not the best choice if the devices are heterogeneous in terms of type,
>> speed, and size, as we may end up reading from the slower device.
>>
>> Export the function part_stat_read_all() so that the btrfs can determine
>> the device with the least average wait time to use.
>>
>> Cc: linux-block@vger.kernel.org
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> You don't need this, it can be accomplished with part_stat_read, or any
> variety of the helpers in part_stat.h. Thanks,
Oh. I have missed #define part_stat_read. It works for now.
We don't have to export part_stat_read_all() as in this patch.
Sorry for the noise.
Thanks, Anand
>
> Josef
next prev parent reply other threads:[~2020-10-28 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1603751876.git.anand.jain@oracle.com>
2020-10-26 23:55 ` [PATCH RFC 1/7] block: export part_stat_read_all Anand Jain
2020-10-27 18:09 ` Josef Bacik
2020-10-28 8:26 ` Anand Jain [this message]
2020-10-26 23:55 ` [PATCH RFC 2/7] block: export part_stat_read_inflight Anand Jain
2020-10-27 18:10 ` Josef Bacik
2020-10-28 8:32 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551a851b-fbaf-3173-09a5-8cbd92b2e7a2@oracle.com \
--to=anand.jain@oracle.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).