From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
Frank Steiner <fsteiner-mail1@bio.ifi.lmu.de>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 1/3] block: introduce LED block device activity trigger
Date: Sun, 28 Jul 2019 19:46:13 +0200 [thread overview]
Message-ID: <5630049e-7ab7-e48e-894d-b07a87fe6c25@gmail.com> (raw)
In-Reply-To: <CAC5umygzNj=7LjzrzrVgOyLiZrKckaCgH68j0COFuWvX1yZAzA@mail.gmail.com>
Hi Akinobu,
On 7/28/19 3:51 PM, Akinobu Mita wrote:
> 2019年7月27日(土) 6:22 Jacek Anaszewski <jacek.anaszewski@gmail.com>:
>>
>> Hi Akinobu,
>>
>> Thank you for the v2. I've checked and it works as expected.
>>
>> One thing is missing though - ABI documentation.
>>
>> Please add Documentation/ABI/testing/sysfs-class-led-trigger-blk
>> and document read, write and discard files.
>
> OK. I'll add document like below.
>
> What: /sys/class/leds/<led>/interval
> Date: Aug 2019
> KernelVersion: 5.4
> Contact: linux-leds@vger.kernel.org
> Description:
> Specifies the duration of the LED blink in milliseconds.
> Defaults to 50 ms.
>
> What: /sys/class/leds/<led>/read
> Date: Aug 2019
> KernelVersion: 5.4
> Contact: linux-leds@vger.kernel.org
> Description:
> Signal data read on the block device.
> If set to 0, the LED will not blink on data read.
> If set to 1 (default), the LED will blink for the milliseconds
> specified in interval to signal data read.
>
> What: /sys/class/leds/<led>/write
> Date: Aug 2019
> KernelVersion: 5.4
> Contact: linux-leds@vger.kernel.org
> Description:
> Signal data written on the block device.
> If set to 0, the LED will not blink on data written.
> If set to 1 (default), the LED will blink for the milliseconds
> specified in interval to signal data written.
>
> What: /sys/class/leds/<led>/discard
> Date: Aug 2019
> KernelVersion: 5.4
> Contact: linux-leds@vger.kernel.org
> Description:
> Signal data discarded on the block device.
> If set to 0, the LED will not blink on data discarded.
> If set to 1 (default), the LED will blink for the milliseconds
> specified in interval to signal data discarded.
>
Looks good, please submit it officially.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-07-28 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 14:59 [PATCH v2 0/3] introduce LED block device activity trigger Akinobu Mita
2019-07-22 14:59 ` [PATCH v2 1/3] block: " Akinobu Mita
2019-07-23 2:04 ` kbuild test robot
2019-07-23 15:26 ` Akinobu Mita
2019-07-23 2:22 ` kbuild test robot
2019-07-23 15:28 ` Akinobu Mita
2019-07-26 21:22 ` Jacek Anaszewski
2019-07-28 13:51 ` Akinobu Mita
2019-07-28 17:46 ` Jacek Anaszewski [this message]
2019-07-22 14:59 ` [PATCH v2 2/3] ledtrig-blk: add interface to stop and restart polling disk stats Akinobu Mita
2019-07-22 14:59 ` [PATCH v2 3/3] scsi: sd: stop polling disk stats by ledtrig-blk during runtime suspend Akinobu Mita
2019-08-10 15:41 ` [PATCH v2 0/3] introduce LED block device activity trigger Frank Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5630049e-7ab7-e48e-894d-b07a87fe6c25@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=dmurphy@ti.com \
--cc=fsteiner-mail1@bio.ifi.lmu.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).