From: Jens Axboe <axboe@kernel.dk>
To: Marco Elver <elver@google.com>
Cc: syzbot <syzbot+4f8bfd804b4a1f95b8f6@syzkaller.appspotmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] KCSAN: data-race in sbitmap_queue_clear / sbitmap_queue_clear (3)
Date: Mon, 25 Oct 2021 10:47:25 -0600 [thread overview]
Message-ID: <593a206e-5a02-e518-2913-5042686cc846@kernel.dk> (raw)
In-Reply-To: <CANpmjNNVh65W00BBRFWwUDp0F4+8RXnU7azqxbpiLuvuev6xEQ@mail.gmail.com>
On 10/25/21 10:03 AM, Marco Elver wrote:
> On Mon, 25 Oct 2021 at 17:40, Jens Axboe <axboe@kernel.dk> wrote:
>> On 10/25/21 8:29 AM, Marco Elver wrote:
>>> On Mon, 25 Oct 2021 at 15:36, Jens Axboe <axboe@kernel.dk> wrote:
>>> [...]
>>>>> write to 0xffffe8ffffd145b8 of 4 bytes by interrupt on cpu 1:
>>>>> sbitmap_queue_clear+0xca/0xf0 lib/sbitmap.c:606
>>>>> blk_mq_put_tag+0x82/0x90
>>>>> __blk_mq_free_request+0x114/0x180 block/blk-mq.c:507
>>>>> blk_mq_free_request+0x2c8/0x340 block/blk-mq.c:541
>>>>> __blk_mq_end_request+0x214/0x230 block/blk-mq.c:565
>>>>> blk_mq_end_request+0x37/0x50 block/blk-mq.c:574
>>>>> lo_complete_rq+0xca/0x170 drivers/block/loop.c:541
>>>>> blk_complete_reqs block/blk-mq.c:584 [inline]
>>>>> blk_done_softirq+0x69/0x90 block/blk-mq.c:589
>>>>> __do_softirq+0x12c/0x26e kernel/softirq.c:558
>>>>> run_ksoftirqd+0x13/0x20 kernel/softirq.c:920
>>>>> smpboot_thread_fn+0x22f/0x330 kernel/smpboot.c:164
>>>>> kthread+0x262/0x280 kernel/kthread.c:319
>>>>> ret_from_fork+0x1f/0x30
>>>>>
>>>>> write to 0xffffe8ffffd145b8 of 4 bytes by interrupt on cpu 0:
>>>>> sbitmap_queue_clear+0xca/0xf0 lib/sbitmap.c:606
>>>>> blk_mq_put_tag+0x82/0x90
>>>>> __blk_mq_free_request+0x114/0x180 block/blk-mq.c:507
>>>>> blk_mq_free_request+0x2c8/0x340 block/blk-mq.c:541
>>>>> __blk_mq_end_request+0x214/0x230 block/blk-mq.c:565
>>>>> blk_mq_end_request+0x37/0x50 block/blk-mq.c:574
>>>>> lo_complete_rq+0xca/0x170 drivers/block/loop.c:541
>>>>> blk_complete_reqs block/blk-mq.c:584 [inline]
>>>>> blk_done_softirq+0x69/0x90 block/blk-mq.c:589
>>>>> __do_softirq+0x12c/0x26e kernel/softirq.c:558
>>>>> run_ksoftirqd+0x13/0x20 kernel/softirq.c:920
>>>>> smpboot_thread_fn+0x22f/0x330 kernel/smpboot.c:164
>>>>> kthread+0x262/0x280 kernel/kthread.c:319
>>>>> ret_from_fork+0x1f/0x30
>>>>
>>>> This is just a per-cpu alloc hint, it's racy by nature. What's the
>>>> preferred way to silence these?
>>>
>>> That was my guess, but couldn't quite say. We started looking at
>>> write/write races as more likely to be harmful (vs. just read/write),
>>> and are inclined to let syzbot send out more of such reports. Marking
>>> intentional ones would be ideal so we'll be left with the
>>> unintentional ones.
>>>
>>> I would probably use WRITE_ONCE(), just to make sure the compiler
>>> doesn't play games here; or if the code is entirely tolerant to even
>>> the compiler miscompiling things, wrap the thing in data_race().
>>
>> It's entirely tolerant, so something like this would do it?
>
> Yup, looks reasonable,
>
> Acked-by: Marco Elver <elver@google.com>
OK thanks, I'll queue it up for 5.16.
--
Jens Axboe
prev parent reply other threads:[~2021-10-25 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 11:16 [syzbot] KCSAN: data-race in sbitmap_queue_clear / sbitmap_queue_clear (3) syzbot
2021-10-25 13:35 ` Jens Axboe
2021-10-25 14:29 ` Marco Elver
2021-10-25 15:40 ` Jens Axboe
2021-10-25 16:03 ` Marco Elver
2021-10-25 16:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=593a206e-5a02-e518-2913-5042686cc846@kernel.dk \
--to=axboe@kernel.dk \
--cc=elver@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4f8bfd804b4a1f95b8f6@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).