From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAC2C433E0 for ; Sat, 16 May 2020 16:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 292DA2065C for ; Sat, 16 May 2020 16:50:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mcqE0ZP1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbgEPQub (ORCPT ); Sat, 16 May 2020 12:50:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbgEPQua (ORCPT ); Sat, 16 May 2020 12:50:30 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8FA4C061A0C; Sat, 16 May 2020 09:50:29 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id a21so5461784ljj.11; Sat, 16 May 2020 09:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f99U+q5cMTjr+AScEQdDuV6vKmP7Ztj+erax4cbrEps=; b=mcqE0ZP1L8fA9oZpjPLnHTQxj9DISlSkdUSjDS5MKMbk/j+03hUQLwd6z3B8B8MDVI wRn1/6n3jL0HPIM4eaeTkrvvTUGSqbcAk/L2fOqZmYQVUokExZrC15lpCNnoH7IEgvAs FyguYQs3v3ii5LK8OmRIpf8e3t3P8p6QuUeujYWdySBsdFwdmARutnbMCIFqIJuNW7hL RKu+0D0hxIucdDXrYurm/1/Lkhpk7yqccI9NNjKbY+vbIxD33Tbumf5ronaI/MRabGYL RqQiC0GdNh4HP942YsV0i0iVEhex68raCr/Du8jsmbBNvWi2DYljbPYjpyRKV2Z6+fPV +jsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f99U+q5cMTjr+AScEQdDuV6vKmP7Ztj+erax4cbrEps=; b=KNHLNnMTR+PgCpJC1H94tIlZOusxpNkj+Kea7G7gv50m7VTfavOW8QMyOx93ng5J1a AoL7SQZDV2RIKnOc+0W47KApeOlV47zyLcTQjAsetMWZD9n/ykYihrtFGJXkZtxpc9CF J3p+l19t61rVDFAJ4uhDeOkWoovLlMxv/KbUPPsEWUjgas1z77rnw/LhPT6IPYfxgvd1 m9AiwO48hByRvQ1u+/lPEI0j75ux//EnYW+NjnEe/zkJjpJFUEVIgQlCZUa2XHT7dhNT lDXC621vQ4/idMpUszYiReWtZRwmAkPy9d/ZJSWxMEDp/am2rDrA3n2R0SzT3XUtbvXg MVVg== X-Gm-Message-State: AOAM530eGSWqGENItRcmVr2tWFQ97i5cdTNItRvr48IisxxJSx26yWzS JZ/teaqQ1yQhw6rQTu5OKXbCfPqt X-Google-Smtp-Source: ABdhPJwIUIqwc5E8sr7K7W7qAuT9oG3a1T0Jbo8c/KLrXv9Oy6CPNoaLxRW7tfNYuUSYHEQnUic1Gw== X-Received: by 2002:a2e:b043:: with SMTP id d3mr5189656ljl.77.1589647826805; Sat, 16 May 2020 09:50:26 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id f5sm3440127lfh.84.2020.05.16.09.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2020 09:50:26 -0700 (PDT) Subject: Re: [PATCH v5 4/6] partitions/efi: Support GPT entry lookup at a non-standard location To: Randy Dunlap , Jens Axboe , Thierry Reding , Jonathan Hunter , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , David Heidelberg , Peter Geis , Stephen Warren , Nicolas Chauvet , Ulf Hansson , Adrian Hunter , Billy Laws , =?UTF-8?Q?Nils_=c3=96stlund?= , Christoph Hellwig , Ard Biesheuvel , Davidlohr Bueso Cc: linux-tegra@vger.kernel.org, linux-block@vger.kernel.org, Andrey Danin , Gilles Grandou , Ryan Grachek , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Steve McIntyre , linux-efi References: <20200516153644.13748-1-digetx@gmail.com> <20200516153644.13748-5-digetx@gmail.com> <2ae298ca-016a-8867-52dd-86d99b9e0f3b@infradead.org> From: Dmitry Osipenko Message-ID: <595392b8-d950-4be6-f6cf-e274b4760b94@gmail.com> Date: Sat, 16 May 2020 19:50:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <2ae298ca-016a-8867-52dd-86d99b9e0f3b@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org 16.05.2020 18:51, Randy Dunlap пишет: > On 5/16/20 8:36 AM, Dmitry Osipenko wrote: >> diff --git a/block/partitions/efi.c b/block/partitions/efi.c >> index b64bfdd4326c..3af4660bc11f 100644 >> --- a/block/partitions/efi.c >> +++ b/block/partitions/efi.c >> @@ -621,6 +621,14 @@ static int find_valid_gpt(struct parsed_partitions *state, gpt_header **gpt, >> if (!good_agpt && force_gpt) >> good_agpt = is_gpt_valid(state, lastlba, &agpt, &aptes); >> >> + /* The force_gpt_sector is used by NVIDIA Tegra partition parser in >> + * order to convey a non-standard location of the GPT entry for lookup. >> + * By default force_gpt_sector is set to 0 and has no effect. >> + */ > > Please fix the multi-line comment format as described in > Documentation/process/coding-style.rst. > >> + if (!good_agpt && force_gpt && state->force_gpt_sector) >> + good_agpt = is_gpt_valid(state, state->force_gpt_sector, >> + &agpt, &aptes); >> + >> /* The obviously unsuccessful case */ >> if (!good_pgpt && !good_agpt) >> goto fail; > > thanks. > Hello Randy, I know that it's not a proper kernel-style formatting, but that's the style used by the whole efi.c source code and I wanted to maintain the same style, for consistency. Of course I can change to a proper style if it's more desirable than the consistency. Thank you for the comment!