From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5ACAC433C1 for ; Mon, 29 Mar 2021 06:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C8B76192B for ; Mon, 29 Mar 2021 06:35:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbhC2Geu (ORCPT ); Mon, 29 Mar 2021 02:34:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:35900 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbhC2Gen (ORCPT ); Mon, 29 Mar 2021 02:34:43 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D36EAB13D; Mon, 29 Mar 2021 06:34:41 +0000 (UTC) Subject: Re: [PATCH 7/8] block: refactor the bounce buffering code To: Christoph Hellwig , Jens Axboe , Khalid Aziz , "Martin K. Petersen" , Matthew Wilcox , Hannes Reinecke , Ondrej Zary Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org References: <20210326055822.1437471-1-hch@lst.de> <20210326055822.1437471-8-hch@lst.de> From: Hannes Reinecke Message-ID: <5bf65977-046f-41b3-de54-f72d235b753d@suse.de> Date: Mon, 29 Mar 2021 08:34:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210326055822.1437471-8-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 3/26/21 6:58 AM, Christoph Hellwig wrote: > Get rid of all the PFN arithmetics and just use an enum for the two > remaining options, and use PageHighMem for the actual bounce decision. > > Add a fast path to entirely avoid the call for the common case of a queue > not using the legacy bouncing code. > > Signed-off-by: Christoph Hellwig > --- > block/blk-core.c | 6 ++---- > block/blk-settings.c | 42 ++++++++---------------------------------- > block/blk.h | 16 ++++++++++++---- > block/bounce.c | 35 +++++------------------------------ > include/linux/blkdev.h | 29 +++++++++++------------------ > 5 files changed, 38 insertions(+), 90 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer