From: Bart Van Assche <firstname.lastname@example.org> To: "André Almeida" <email@example.com>, "Gabriel Krisman Bertazi" <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v2 1/1] blk-mq: fill header with kernel-doc Date: Fri, 11 Oct 2019 10:00:41 -0700 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 10/10/19 1:38 PM, André Almeida wrote: > Seems that it's not clear for me the role of these members. Could you > please check if those definitions make sense for you? > > - hctx->dispatch: This queue is used for requests that are ready to be > dispatched to the hardware but for some reason (e.g. lack of resources, > the hardware is to busy and can't get more requests) could not be sent > to the hardware. As soon as the driver can send new requests, those > queued at this list will be sent first for a more fair dispatch. Since > those requests are at the hctx, they can't be requeued or rescheduled > anymore. > > - request_queue->requeue_list: This list is used when it's not possible > to send the request to the associated hctx. This can happen if the > associated CPU or hctx is not available anymore. When requeueing those > requests, it will be possible to send them to new and function queues. Hi André, The hctx->dispatch description looks mostly fine. Can the following part be left out since it looks confusing to me: "Since those requests are at the hctx, they can't be requeued or rescheduled anymore." How about changing the requeue_list description into the following: "requests requeued by a call to blk_mq_requeue_request()". Thanks, Bart.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-08 0:14 André Almeida 2019-10-08 16:35 ` Gabriel Krisman Bertazi 2019-10-08 17:30 ` Bart Van Assche 2019-10-08 18:46 ` Gabriel Krisman Bertazi 2019-10-08 20:01 ` Bart Van Assche 2019-10-10 20:38 ` André Almeida 2019-10-11 17:00 ` Bart Van Assche [this message] 2019-10-08 18:12 ` Bart Van Assche 2019-10-10 20:41 ` André Almeida
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Block Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \ email@example.com firstname.lastname@example.org public-inbox-index linux-block Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block AGPL code for this site: git clone https://public-inbox.org/ public-inbox