linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] floppy: Remove redundant assignment to nr_sectors
@ 2021-04-30  9:26 Jiapeng Chong
  2021-04-30  9:56 ` Denis Efremov
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-30  9:26 UTC (permalink / raw)
  To: efremov; +Cc: axboe, linux-block, linux-kernel, Jiapeng Chong

Variable nr_sectors is set to zero but this value is never
read as it is overwritten later on, hence it is a redundant
assignment and can be removed.

Clean up the following clang-analyzer warning:

drivers/block/floppy.c:2333:2: warning: Value stored to 'nr_sectors' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/block/floppy.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 8a9d222..e96ad5b 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2330,7 +2330,6 @@ static void rw_interrupt(void)
 	if (!drive_state[current_drive].first_read_date)
 		drive_state[current_drive].first_read_date = jiffies;
 
-	nr_sectors = 0;
 	ssize = DIV_ROUND_UP(1 << raw_cmd->cmd[SIZECODE], 4);
 
 	if (reply_buffer[ST1] & ST1_EOC)
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] floppy: Remove redundant assignment to nr_sectors
  2021-04-30  9:26 [PATCH] floppy: Remove redundant assignment to nr_sectors Jiapeng Chong
@ 2021-04-30  9:56 ` Denis Efremov
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Efremov @ 2021-04-30  9:56 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: axboe, linux-block, linux-kernel

Hi,

On 4/30/21 12:26 PM, Jiapeng Chong wrote:
> Variable nr_sectors is set to zero but this value is never
> read as it is overwritten later on, hence it is a redundant
> assignment and can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/block/floppy.c:2333:2: warning: Value stored to 'nr_sectors' is
> never read [clang-analyzer-deadcode.DeadStores].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Looks good, applied.
https://github.com/evdenis/linux-floppy/commit/a2d3f991fb51beb1376fb257a316e9b9e3c99737

I slightly changed the title. I guess this will go with other cleanup patches
to 5.14 release. Jens already merged 5.13 patches to master.

Thanks,
Denis

> ---
>  drivers/block/floppy.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 8a9d222..e96ad5b 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2330,7 +2330,6 @@ static void rw_interrupt(void)
>  	if (!drive_state[current_drive].first_read_date)
>  		drive_state[current_drive].first_read_date = jiffies;
>  
> -	nr_sectors = 0;
>  	ssize = DIV_ROUND_UP(1 << raw_cmd->cmd[SIZECODE], 4);
>  
>  	if (reply_buffer[ST1] & ST1_EOC)
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-30  9:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30  9:26 [PATCH] floppy: Remove redundant assignment to nr_sectors Jiapeng Chong
2021-04-30  9:56 ` Denis Efremov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).