linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Javier González" <javier@javigon.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
	"Matias Bjørling" <mb@lightnvm.io>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] : Switch to use new generic UUID API
Date: Thu, 24 Jan 2019 14:17:37 +0100	[thread overview]
Message-ID: <6D748F08-F9F9-4DFB-84DF-63E97C691013@javigon.com> (raw)
In-Reply-To: <20190124121659.GH9224@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]


> On 24 Jan 2019, at 13.16, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> On Mon, Jan 21, 2019 at 09:47:32AM +0100, Christoph Hellwig wrote:
>> On Thu, Jan 10, 2019 at 04:30:51PM +0200, Andy Shevchenko wrote:
>>> There are new types and helpers that are supposed to be used in new code.
>>> 
>>> As a preparation to get rid of legacy types and API functions do
>>> the conversion here.
>> 
>> This seems to miss a "lightnvm" in the subject line.
>> 
>>> static inline void pblk_setup_uuid(struct pblk *pblk)
>>> {
>>> +	guid_gen((guid_t *)&pblk->instance_uuid);
>>> }
>> 
>> I think we can just kill this wrapper.
>> 
>> But more importantly the instance_uuid fied, and the header.uuid one
>> it is copied from should be turned into an actual guid_t, the memcpys
>> and memcmps should also be replaced with the proper UUID API.
> 
> header.uuid is defined using __u8 type, I'm not sure we can use guid_t there.
> 

We can turn it into a guid_t and bump the minor version.

Javier

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-01-24 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 14:30 [PATCH v1] : Switch to use new generic UUID API Andy Shevchenko
2019-01-21  8:47 ` Christoph Hellwig
2019-01-24 12:16   ` Andy Shevchenko
2019-01-24 13:17     ` Javier González [this message]
2019-01-24 13:36       ` Andy Shevchenko
2019-01-24 13:45         ` Javier González
2019-01-24 14:13           ` Andy Shevchenko
2019-01-24 14:36             ` Javier González
2019-01-24 16:38               ` Andy Shevchenko
2019-01-24 16:41                 ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6D748F08-F9F9-4DFB-84DF-63E97C691013@javigon.com \
    --to=javier@javigon.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).