From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C35CC433E0 for ; Wed, 10 Feb 2021 15:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 079E664E85 for ; Wed, 10 Feb 2021 15:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231609AbhBJPyv (ORCPT ); Wed, 10 Feb 2021 10:54:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230328AbhBJPyt (ORCPT ); Wed, 10 Feb 2021 10:54:49 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8815FC06174A for ; Wed, 10 Feb 2021 07:54:09 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id b3so3147683wrj.5 for ; Wed, 10 Feb 2021 07:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=diEVw5/O8/Cy8oiBHC8W2XTuoIkYQ2nZAo/0L37zzlA=; b=WrxKkBGiNt0lpiBKQGILDGQoZOf6yr0kAlqHLYYFYcjMSJ8NcuITvVF+C9QqhvC2Uy +bgxUTlXmwUCh5S9/or4Zeju6IG4TBVuqSZI8F999LcKPyQHlhpbczAbbqulxjTJUG8U o0L2/lMRI1xuAP8bfX8tiOtKLvjJE9dUwVs9BhgwvWTdDxttqbGEAtr0O2SoJP+9B9jV 8HFZUkAI0MJtPvIkG02y+T4g6VBbJd7dz0CmyolNqRQYomSQaHwGoFTrWiQ49U/gPPiy xx8hodBASgNWiO64H9WubL+A13Jn5Dhe0NQ50NoHP6UgV6aRyPDQiyvOpb+07x376uZW d4XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=diEVw5/O8/Cy8oiBHC8W2XTuoIkYQ2nZAo/0L37zzlA=; b=TKkD398jxdaHYIhr+BdD1k/TaJ6sAMYwZPxbrky2AkhBmROsvhmwlFfro1f3UdqTMf eVzoAtM5w6QqHTZI1NulzCs+5+qUWLpYSf/EAflrIt7+Z9fRUgAC888Jfp47qG5YEr/I L8XsIpCeSej1QNyuFzoYZG35t5vrn8FLsVx+kBZiLXQwelERGsrzHlpuiSYlbXAHPJHM /9KFT9yJD1eupUozVS9L/5qcFyWSZQnLFuV5HF2oOFqPIdsMObnnkRlt4Teof7F+RoTY WoguUrXOIlmE/5GR5YU99XXvxSvs+CaBrRO463my267bchOOi3VZu73bShWmVrDt899r Lgtw== X-Gm-Message-State: AOAM530caBshqnkBhpZVT79muaYkdynr6UtCK2XHo62CFJ6BeRNIs/pE VHlh7lzYSXHxO35pXRZVCZR8BA== X-Google-Smtp-Source: ABdhPJw1QFVpKunbCZwyU8NE9x73nKK0p7MMY16TugmV4n0fp/nCj5n532ESqNTyy0hqmas54no7zQ== X-Received: by 2002:adf:ecd2:: with SMTP id s18mr4408622wro.311.1612972448181; Wed, 10 Feb 2021 07:54:08 -0800 (PST) Received: from [192.168.0.13] ([83.216.184.132]) by smtp.gmail.com with ESMTPSA id z6sm2787750wmi.39.2021.02.10.07.54.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Feb 2021 07:54:07 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH 1/2] bfq: remove some useless logic of bfq_update_next_in_service() From: Paolo Valente In-Reply-To: Date: Wed, 10 Feb 2021 16:54:15 +0100 Cc: Oleksandr Natalenko , Chunguang Xu , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <6FFDC28C-BB1B-45F8-B2E9-2BCDF2CC1B61@linaro.org> References: <1611917485-584-1-git-send-email-brookxu@tencent.com> <20210210152034.puimoewzgtnnp2zl@spock.localdomain> To: Jens Axboe X-Mailer: Apple Mail (2.3445.104.11) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > Il giorno 10 feb 2021, alle ore 16:21, Jens Axboe ha = scritto: >=20 > On 2/10/21 8:20 AM, Oleksandr Natalenko wrote: >> On Wed, Feb 10, 2021 at 12:13:29PM +0100, Paolo Valente wrote: >>>=20 >>>=20 >>>> Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu = ha scritto: >>>>=20 >>>> From: Chunguang Xu >>>>=20 >>>> The if statement at the end of the function is obviously useless, >>>> maybe we can delete it. >>>>=20 >>>=20 >>> Thanks for spotting this mistake. >>>=20 >>> Acked-by: Paolo Valente >>>=20 >>>> Signed-off-by: Chunguang Xu >>>> --- >>>> block/bfq-wf2q.c | 3 --- >>>> 1 file changed, 3 deletions(-) >>>>=20 >>>> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c >>>> index 26776bd..070e34a 100644 >>>> --- a/block/bfq-wf2q.c >>>> +++ b/block/bfq-wf2q.c >>>> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct = bfq_sched_data *sd, >>>>=20 >>>> sd->next_in_service =3D next_in_service; >>>>=20 >>>> - if (!next_in_service) >>>> - return parent_sched_may_change; >>>> - >>=20 >> Unless I'm missing something, this has already been fixed here: >>=20 >> = https://git.kernel.dk/cgit/linux-block/commit/?h=3Dfor-5.12/block&id=3D1a2= 3e06cdab2be07cbda460c6417d7de564c48e6 >=20 > Yep indeed. >=20 I seemed to remember this patch as well. But my memory is rather weak. > --=20 > Jens Axboe